Skip OwnerNotActivated error on unconfigured repos #516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 599 599
Lines 16247 16248 +1
=======================================
+ Hits 14861 14862 +1
Misses 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 599 599
Lines 16247 16248 +1
=======================================
+ Hits 14861 14862 +1
Misses 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=====================================
Coverage 95.77 95.77
=====================================
Files 774 774
Lines 17103 17104 +1
=====================================
+ Hits 16380 16381 +1
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
rohitvinnakota-codecov
had a problem deploying
to
staging
GitHub Actions
Failure
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
This is a follow up to codecov/engineering-team#1253.
On the front end, we want to show an error inside a page instead of letting
NetworkErrorBoundaryoverwrite the whole page. Furthermore, we need repository information to conditionally render Coverage and Bundle Analysis setup tabs regardless of the owner's activation status.With this change, we do not throw an
OwnerNotActivatederror if the repo is not configured, enabling us to display onboarding tabs on the front end without throwing a page level error.More information about the project here.
Please note that this must be merged before codecov/gazebo#2794.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.