Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use new func name in sentry-sdk celery config #997

Closed
wants to merge 5 commits into from

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 21, 2024

It appears we have custom configuration of sentry-sdk to address this issue with celery - getsentry/sentry-python#1416

When bumping to the latest version of sentry-sdk, we need to rename the function _wrap_apply_async --> _wrap_task_run

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (70ec67f) to head (239c638).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   96.03%   96.03%   -0.01%     
==========================================
  Files         828      828              
  Lines       19166    19156      -10     
==========================================
- Hits        18407    18397      -10     
  Misses        759      759              
Flag Coverage Δ
unit 92.33% <ø> (+0.02%) ⬆️
unit-latest-uploader 92.33% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suejung-sentry suejung-sentry changed the title fix: Remove redundant sentry celery config fix: Use new func name in celery config Nov 21, 2024
@suejung-sentry suejung-sentry changed the title fix: Use new func name in celery config fix: Use new func name in sentry-sdk celery config Nov 21, 2024
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@9c31870...12361de

@suejung-sentry suejung-sentry marked this pull request as ready for review November 21, 2024 22:23
@suejung-sentry
Copy link
Contributor Author

This PR requires some whack-a-mole with deps versions. We'll handle downgrading shared to be compatible with api instead of the other way around with this pr - codecov/shared#432

@suejung-sentry suejung-sentry deleted the sshin/fix/sentry-celery branch November 22, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants