-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pin deps to previous version for compat with api #432
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 90.56% 89.81% -0.75%
==========================================
Files 390 324 -66
Lines 11768 9379 -2389
Branches 1974 1677 -297
==========================================
- Hits 10658 8424 -2234
+ Misses 1026 891 -135
+ Partials 84 64 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NOTE here are the errors I'm seeing: API
Same Workerwhen spinning up the docker container
when running pytest
|
@@ -1385,15 +1385,15 @@ wheels = [ | |||
|
|||
[[package]] | |||
name = "sentry-sdk" | |||
version = "2.18.0" | |||
version = "2.13.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only package thats actually being downgraded here, and I would suggest that you not pin this, but rather define a lower bound, like for the others.
The other packages are not actually being downgraded in the lockfile, but rather their minimum version is being lowered, which has an effect on api/worker pulling in shared
and having to resolve dependency versions. So in api/worker, we could end up with lower dependencies.
If you are hitting actual errors with deprecated/removed API, you can pin this to a lower version using abs<x.y.z
syntax like for sqlalchemy
in the pyproject.toml
.
Not quite sure whether you want to do that here in this repo, or in api/worker rather.
Pin deps to version that will be compatible with that currently in
api
andworker
. Sets deps versions here in shared asminimum(api, worker)
versionapi requirements.txt
worker requirements.txt
Follows up to https://github.com/codecov/shared/pull/423/files
Tested by spinning up api and worker using this version of shared with
docker compose up
& checking for any build errors. Also ranpytest
within those containers for any build errors there