This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Send Upload Token via Header #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be good after you fix tests, will review again before merging in |
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 45.78% 45.82% +0.03%
==========================================
Files 20 20
Lines 2859 2859
==========================================
+ Hits 1309 1310 +1
+ Misses 1550 1549 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thomasrockhu
approved these changes
Jun 9, 2021
sbeidas
added a commit
that referenced
this pull request
Jul 9, 2021
* Fix go regex (#436) * Send Upload Token via Header (#439) * Send token via HTTP header vs. URL param * Revert testing change * Update script to use token in header * update SHASUM * maybe fix tests? * Undo accidental deletion * More test fixes * fix build Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
thomasrockhu
added a commit
that referenced
this pull request
Jul 10, 2021
* Releasing new version of the uploader (#445) * Fix go regex (#436) * Send Upload Token via Header (#439) * Send token via HTTP header vs. URL param * Revert testing change * Update script to use token in header * update SHASUM * maybe fix tests? * Undo accidental deletion * More test fixes * fix build Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com> * Update to 1.0.4 Co-authored-by: Subhi Beidas <subhibeidas@gmail.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
thomasrockhu
added a commit
that referenced
this pull request
Jul 20, 2021
* Releasing new version of the uploader (#445) * Fix go regex (#436) * Send Upload Token via Header (#439) * Send token via HTTP header vs. URL param * Revert testing change * Update script to use token in header * update SHASUM * maybe fix tests? * Undo accidental deletion * More test fixes * fix build Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com> * Update to 1.0.4 Co-authored-by: Subhi Beidas <subhibeidas@gmail.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
thomasrockhu
added a commit
that referenced
this pull request
Jul 21, 2021
* Pull in `1.0.4` into `master` (#448) * Releasing new version of the uploader (#445) * Fix go regex (#436) * Send Upload Token via Header (#439) * Send token via HTTP header vs. URL param * Revert testing change * Update script to use token in header * update SHASUM * maybe fix tests? * Undo accidental deletion * More test fixes * fix build Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com> * Update to 1.0.4 Co-authored-by: Subhi Beidas <subhibeidas@gmail.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com> * 1.0.5 - Fix token uploads for self-hosted (#454) * fix: Prevent deploys if tag is not unique (#452) * docs: Add deprecation warning (#451) * fix: add query support for token (self-hosted) (#453) * fix: add query support for token (self-hosted) * fix: mask the token in output Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com> * chore: bump version * chore: trigger new deploy with tag 1.0.5 * fail if release fails (#447) * fix: Do not set PR on closed GitHub PRs (#456) * fix: Update GitHub Actions server URL (#457) * fix: Update GitHub Actions server URL * fix: Update tests * patch: bump to 1.0.6 (#458) Co-authored-by: Subhi Beidas <subhibeidas@gmail.com> Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com> Co-authored-by: Joe Becher <71270647+drazisil-codecov@users.noreply.github.com> Co-authored-by: Joe Becher <joe@codecov.io> Co-authored-by: Matthew Berryman <matthew@acrossthecloud.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Send the upload token via header, which is more secure than as a URL param.
Tests and Risks?
I updated tests to pass, but not sure there's a good way thus token is being set as a header :(
Update the SHA hash files
Done