Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Pull in 1.0.4 into master #448

Merged
merged 3 commits into from
Jul 10, 2021
Merged

Pull in 1.0.4 into master #448

merged 3 commits into from
Jul 10, 2021

Conversation

thomasrockhu
Copy link
Contributor

Purpose

Due to an issue with our versioning, the previous bash script deployment failed due to a mismatch in version. This push was made directly to production branch as a hotfix. This PR is intaking that change.

Notable Changes

This is merging production into master. There may be some weird git issues down the road, but I don't expect there to be.

Tests and Risks?

None

Update the SHA hash files

Done

sbeidas and others added 2 commits July 9, 2021 23:45
* Fix go regex (#436)

* Send Upload Token via Header (#439)

* Send token via HTTP header vs. URL param

* Revert testing change

* Update script to use token in header

* update SHASUM

* maybe fix tests?

* Undo accidental deletion

* More test fixes

* fix build

Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
@thomasrockhu thomasrockhu requested review from sbeidas and a team July 10, 2021 05:57
@thomasrockhu thomasrockhu changed the title Production Pull in 1.0.4 into master Jul 10, 2021
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #448 (bce8fd5) into master (c3ccd59) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   45.82%   45.76%   -0.06%     
==========================================
  Files          20       20              
  Lines        2859     2856       -3     
==========================================
- Hits         1310     1307       -3     
  Misses       1549     1549              
Flag Coverage Δ
test 39.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov 67.58% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ccd59...bce8fd5. Read the comment docs.

@RA80533
Copy link

RA80533 commented Jul 10, 2021

Just out of curiosity, how did you to make commit bce8fd5?

@thomasrockhu
Copy link
Contributor Author

@RA80533 I pushed the hotfix to production, this was automagically created by GitHub

@thomasrockhu thomasrockhu merged commit d4628f7 into master Jul 10, 2021
@thomasrockhu thomasrockhu deleted the production branch July 10, 2021 06:22
@RA80533
Copy link

RA80533 commented Jul 10, 2021

Was production a temporary branch?

@drazisil-codecov
Copy link
Contributor

Was production a temporary branch?

It is not. It has since been restored and branch protection approved to prevent automatic deletion

thomasrockhu added a commit that referenced this pull request Jul 20, 2021
* Releasing new version of the uploader (#445)

* Fix go regex (#436)

* Send Upload Token via Header (#439)

* Send token via HTTP header vs. URL param

* Revert testing change

* Update script to use token in header

* update SHASUM

* maybe fix tests?

* Undo accidental deletion

* More test fixes

* fix build

Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>

* Update to 1.0.4

Co-authored-by: Subhi Beidas <subhibeidas@gmail.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
thomasrockhu added a commit that referenced this pull request Jul 21, 2021
* Pull in `1.0.4` into `master` (#448)

* Releasing new version of the uploader (#445)

* Fix go regex (#436)

* Send Upload Token via Header (#439)

* Send token via HTTP header vs. URL param

* Revert testing change

* Update script to use token in header

* update SHASUM

* maybe fix tests?

* Undo accidental deletion

* More test fixes

* fix build

Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>

* Update to 1.0.4

Co-authored-by: Subhi Beidas <subhibeidas@gmail.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>

* 1.0.5 - Fix token uploads for self-hosted (#454)

* fix: Prevent deploys if tag is not unique (#452)

* docs: Add deprecation warning (#451)

* fix: add query support for token (self-hosted) (#453)

* fix: add query support for token (self-hosted)

* fix: mask the token in output

Co-authored-by: Tom Hu <thomasrockhu@users.noreply.github.com>

* chore: bump version

* chore: trigger new deploy with tag 1.0.5

* fail if release fails (#447)

* fix: Do not set PR on closed GitHub PRs (#456)

* fix: Update GitHub Actions server URL (#457)

* fix: Update GitHub Actions server URL

* fix: Update tests

* patch: bump to 1.0.6 (#458)

Co-authored-by: Subhi Beidas <subhibeidas@gmail.com>
Co-authored-by: Andrew Jaeger <mrjaeger00@gmail.com>
Co-authored-by: Joe Becher <71270647+drazisil-codecov@users.noreply.github.com>
Co-authored-by: Joe Becher <joe@codecov.io>
Co-authored-by: Matthew Berryman <matthew@acrossthecloud.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants