Add option to show hidden files and directories in IFS browser #1839
Conversation
|
@chrjorgensen Any chance you can fix the conflict? 😬 |
|
@worksofliam Conflict fixed... |
|
Initial reaction and usage of the code is awesome. I need to play with it more before I merge. |
There was a problem hiding this comment.
Very good enhancement!
I have a few suggestions to make and a question:
- Shouldn't a button be added to the browser to toggle between hide/show hidden files? I'm quite sure users will either miss the feature of hit
ctrl+hby mistake and ask why some files disappeared 😅
package.json
Outdated
| }, | ||
| { | ||
| "command": "code-for-ibmi.ifs.toggleShowHiddenFiles", | ||
| "when": "code-for-ibmi:connected && view == ifsBrowser" |
There was a problem hiding this comment.
Is this when clause in the right place? Even if my focus on was on the IFS Browser, I couldn't get it to show up.
There was a problem hiding this comment.
I will remove the command and add an icon in the IFS browser instead.
Co-authored-by: Sébastien Julliand <sebjulliand@gmail.com>
|
@worksofliam The keybinding has been removed and replaced by an icon in the IFS browser navigation menu, as suggested by @sebjulliand Feel free to test and merged, if approved. 🙏 |
There was a problem hiding this comment.
@chrjorgensen Thanks for taking my shortcut consideration into account! I prefer the icon over the shortcut for sure due to it already being used on Mac.
Works good to me. Thanks!
Changes
Up until now the IFS browser shows all files and directories, even the hidden ones with a
.in front of the name.This PR will add an option to show or hide these files and directories in the IFS browser:
The option can be changed in the connection settings:
ALWAYS_SHOW_FILESinifsBrowser.ts) to always show.vscodeand.gitignoreChecklist