Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully rework command titles #1863

Merged

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will recover and continue the changes in PR #1840, which was lost by a subsequent merge of PR #1839:

  • all context menu command titles have had their object removed from the title, since they are activated by right-clicking the object. E.g. "Delete Member" => "Delete"
  • all commands which prompt the user have had their title changed with an appending '...'
  • "Update Member Text" command has been changed to "Change Description" like objects
  • all "Create" command titles have been changed to "New".

Some examples of changes - before and after:

Connection browser view:

image=>image

Object browser view:

image=>image

IFS browser view:

image=>image

What do the team think about these changes? Like? Dislike?

If accepted, I have to update the docs with new command titles and new screenshots...

Checklist

  • have tested my change
  • updated relevant documentation

@chrjorgensen chrjorgensen requested a review from a team February 22, 2024 13:48
@chrjorgensen chrjorgensen self-assigned this Feb 22, 2024
@chrjorgensen chrjorgensen added the enhancement New feature or request label Feb 22, 2024
@worksofliam worksofliam added this to the 2.7.1 milestone Feb 22, 2024
@worksofliam
Copy link
Contributor

@chrjorgensen Please convert this from a draft when it is ready. I am happy to review!

@chrjorgensen chrjorgensen marked this pull request as ready for review February 23, 2024 09:41
@chrjorgensen
Copy link
Collaborator Author

@worksofliam Ah, wasn't aware that it a draft - must have been the default after creating the previous (draft) PR.

Reviews are very welcome! 🙏

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. It's nice to have consistency and also appreciate some fixes to the ordering of some options.

@chrjorgensen chrjorgensen merged commit 77cf732 into codefori:master Feb 23, 2024
1 check passed
@chrjorgensen chrjorgensen deleted the fix/fully-rework-command-titles branch March 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants