Implement remove filter command in object browser #2250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
julesyan
reviewed
Sep 7, 2024
| vscode.commands.registerCommand(`code-for-ibmi.objectBrowser.removeFilter`, async (node?: ObjectBrowserItem) => { | ||
| if (node && node instanceof ObjectBrowserFilterItem) { | ||
| const message = t('objectBrowser.delete.confirm', node.toString()); | ||
| if (await vscode.window.showWarningMessage(message, { modal: true }, t(`Yes`))) { |
There was a problem hiding this comment.
The 'Remove Shortcut' in the IFS browser does not have a warning, would we want to match that functionality more?
1 task
|
Swapping back to draft and will reopen based on suggestion from 2252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new command, "Remove Filter", to the object browser in the IBM i category. The command allows users to remove a filter from the object browser. The implementation includes changes to the command registration and the initialization of the object browser.
This change was added to seperate the difference between deleting an object vs removing the filter (just like we do in the IFS Browser)