Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filters to be deleted even if protected #2252

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #2251
The logic for deleting Object Browser items would prevent filters from being deleted if they were protected.

This PR makes filter item deletable, not mater what.

How to test this PR

  1. Try to delete a protected filter
  2. The confirmation dialog must show up
  3. If confirmed, the filter must be removed

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Sep 10, 2024
@sebjulliand sebjulliand self-assigned this Sep 10, 2024
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Maybe there is some overlap between this and #2250?

@sebjulliand
Copy link
Collaborator Author

Works as expected. Maybe there is some overlap between this and #2250?

A little bit...I guess the command in #2250 should simply be:

vscode.commands.registerCommand(`code-for-ibmi.objectBrowser.removeFilter`, (node:  ObjectBrowserItem, nodes:  ObjectBrowserItem[]) => vscode.commands.executeCommand(`code-for-ibmi.objectBrowser.delete`, node, nodes));

@worksofliam worksofliam merged commit e0e862e into master Sep 17, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete protected filters
2 participants