Merge pull request #5647 from kenjis/fix-BaseController

refactor: make BaseController abstract
codeigniter4 · Feb 3, 2022 · 069cb70 · 069cb70
2 parents 731fb2f + 51fee60
commit 069cb70
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 11 deletions.
diff --git a/app/Controllers/BaseController.php b/app/Controllers/BaseController.php
@@ -19,7 +19,7 @@
  *
  * For security be sure to declare any new methods as protected or private.
  */
-class BaseController extends Controller
+abstract class BaseController extends Controller
 {
     /**
      * Instance of the main Request object.

diff --git a/phpstan-baseline.neon.dist b/phpstan-baseline.neon.dist
@@ -485,11 +485,6 @@ parameters:
 			count: 1
 			path: system/Debug/Exceptions.php
 
-		-
-			message: "#^Parameter \\#4 \\$replacement of function array_splice expects array\\|string, true given\\.$#"
-			count: 1
-			path: system/Debug/Exceptions.php
-
 		-
 			message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
 			count: 1

diff --git a/system/Config/Routes.php b/system/Config/Routes.php
@@ -21,11 +21,6 @@
  * already loaded up and ready for us to use.
  */
 
-// Prevent access to BaseController
-$routes->add('BaseController(:any)', static function () {
-    throw PageNotFoundException::forPageNotFound();
-});
-
 // Prevent access to initController method
 $routes->add('(:any)/initController', static function () {
     throw PageNotFoundException::forPageNotFound();