Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make BaseController abstract #5647

Merged
merged 2 commits into from
Feb 3, 2022
Merged

refactor: make BaseController abstract #5647

merged 2 commits into from
Feb 3, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 3, 2022

Description

  • no need to instantiate

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Feb 3, 2022
@kenjis kenjis mentioned this pull request Feb 3, 2022
Merged
4 tasks
@kenjis kenjis merged commit 069cb70 into codeigniter4:develop Feb 3, 2022
@kenjis kenjis deleted the fix-BaseController branch February 3, 2022 04:15
@kenjis kenjis mentioned this pull request Feb 7, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @lonnieezell