Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move logic to prevent access to initController #5648

Merged
merged 1 commit into from
Feb 3, 2022
Merged

refactor: move logic to prevent access to initController #5648

merged 1 commit into from
Feb 3, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 3, 2022 •
edited
Loading

Description

  • it should prevent when auto routing

Checklist:

  • Needs refactor: make BaseController abstract #5647 (and rebase)
  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Feb 3, 2022
@kenjis kenjis force-pushed the fix-prevent-access-to-initController branch from fa60803 to 43ede27 Compare February 3, 2022 04:16
@kenjis kenjis merged commit bb98bda into codeigniter4:develop Feb 3, 2022
@kenjis kenjis deleted the fix-prevent-access-to-initController branch February 3, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan