Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.1 #4883

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jun 26, 2021

Description:
PHP 8.1 will be released in a few months and we should ensure the framework is compatible by then.

Detected issues:

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan force-pushed the php80100-workflow branch 2 times, most recently from 5b29225 to 2d4c76c Compare June 26, 2021 17:23
@paulbalandan paulbalandan marked this pull request as draft June 26, 2021 17:24
.github/workflows/test-phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/test-phpunit.yml Show resolved Hide resolved
@paulbalandan
Copy link
Member Author

Initial incompat we have is the session handlers extending SessionHandlerInterface.

During inheritance of SessionHandlerInterface: Uncaught ErrorException: Declaration of
CodeIgniter\Session\Handlers\ArrayHandler::gc($maxlifetime): bool should be compatible
with SessionHandlerInterface::gc(int $max_lifetime): int|false

@lonnieezell
Copy link
Member

Where are we at on this? It's a couple months old now, and I'd love to get some of these cleaned up and either merged or closed.

@MGatner
Copy link
Member

MGatner commented Aug 18, 2021

Glad this is going smoothly! Should make for an easy transition this fall so we can focus on the 7.4 minimum.

@paulbalandan
Copy link
Member Author

I'll be splitting unrelated changes in separate PRs.

@paulbalandan paulbalandan changed the title Test framework for compatibility against PHP 8.1 Add support for PHP 8.1 Nov 25, 2021
@paulbalandan
Copy link
Member Author

All green 🎉

I just would have to comment. Tests in PHP 8.1, excluding MySQLi, are pretty fast. Slow tests are now between 20-30 tests.

@MGatner
Copy link
Member

MGatner commented Nov 25, 2021

That's awesome! I'm excited to see what dropping 7.3 does to our overall Actions runtime. If 8.1 is noticeably faster would should be looking at a sizable improvement.

8.1 should land today! Merge when you're ready.

@paulbalandan paulbalandan merged commit 0a55082 into codeigniter4:develop Nov 25, 2021
@paulbalandan paulbalandan deleted the php80100-workflow branch November 25, 2021 14:24
@MGatner
Copy link
Member

MGatner commented Nov 26, 2021

Just in time! 8.1 is now stable on setup-php: https://github.com/shivammathur/setup-php/releases/tag/2.16.0

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 12, 2021
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants