-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated usage of null
on string
params of internal functions
#5371
Merged
kenjis
merged 1 commit into
codeigniter4:develop
from
paulbalandan:deprecated-null-on-internal-fn
Nov 25, 2021
Merged
Fix deprecated usage of null
on string
params of internal functions
#5371
kenjis
merged 1 commit into
codeigniter4:develop
from
paulbalandan:deprecated-null-on-internal-fn
Nov 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
deprecated-null-on-internal-fn
branch
from
November 21, 2021 11:47
a4876d0
to
78c18fd
Compare
MGatner
requested changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one I didn't look very closely at is Time
, I can revisit if you get two other reviews.
paulbalandan
force-pushed
the
deprecated-null-on-internal-fn
branch
from
November 21, 2021 13:36
78c18fd
to
4c50b10
Compare
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
kenjis
reviewed
Nov 22, 2021
paulbalandan
force-pushed
the
deprecated-null-on-internal-fn
branch
from
November 22, 2021 12:45
4c50b10
to
8673228
Compare
kenjis
approved these changes
Nov 23, 2021
MGatner
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4883
Checklist: