Fix highlighting in database debug toolbar

[vlakoff]

Highlighting wasn't working for multiple-word terms, as they were searched in the SQL string with nbsp entities instead of regular spaces.

This code could be optimized, though it's not crucial as it's a debug function.

[vlakoff]

Added a commit implementing replacement using regexp with word boundaries, to avoid overlaps / false positives with strings such as "OR", "IN"…

[sfadschm]

Can you add before/after schreenshots?

[vlakoff]

I confirmed the fix, but if ever you want screenshots of this toolbar content, you may have a look at #5136.

[sfadschm]

I confirmed the fix, but if ever you want screenshots of this toolbar content, you may have a look at #5136.

There is unfortunately none of the key words changed here visible in the other PR. Would be great to see just one example what has been fixed in this PR, too.

[paulbalandan]

Since this PR addresses an error in highlighting multiple-word identifiers, please add before/after screenshots, as @sfadschm suggested, that show there are indeed problems with the current and how this PR fixes them.

[vlakoff]

Before:

After:

[vlakoff]

Maybe we should add the ASC and DESC keywords?

[vlakoff]

Also, I'd suggest either highlighting commas in addition to parentheses, or not highlighting parentheses. Your pick?

[sfadschm]

I think adding the keywords would be good, but would rather remove the parentheses. But lets wait for other calls.

[kenjis]

I would like removing parentheses, adding ASC and DESC.

[paulbalandan]

Let's highlight only keywords, leaving out parentheses and other punctuation marks.

[vlakoff]

• Removed the highlighting of parentheses
• Added ASC and DESC keywords
• Reduced the number of commits by removing the commits related to the Rector warning

[paulbalandan]

Thank you, @vlakoff