Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: isCLI() in CLIRequest and IncomingRequest #5653

Merged
merged 1 commit into from
Feb 16, 2022
Merged

refactor: isCLI() in CLIRequest and IncomingRequest #5653

merged 1 commit into from
Feb 16, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 4, 2022 •
edited
Loading

Description
From #5649

  • no need to depend on is_cli()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Feb 4, 2022
@samsonasik samsonasik merged commit 93b8bca into codeigniter4:develop Feb 16, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the refactor-CLI-Incomming-Request branch February 17, 2022 01:08
@marios88 marios88 mentioned this pull request Jun 15, 2022
Closed
@kenjis kenjis mentioned this pull request Jun 15, 2022
Merged
kenjis added a commit that referenced this pull request Jun 16, 2022
@kenjis
Revert "Merge pull request #5653 from kenjis/refactor-CLI-Incomming-R…
ed22aa5 
…equest"

This reverts commit 93b8bca, reversing
changes made to 048d997.
@kenjis kenjis mentioned this pull request Jun 16, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik