Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: CodeIgniter $context check #6047

Merged
merged 1 commit into from
May 30, 2022
Merged

refactor: CodeIgniter $context check #6047

merged 1 commit into from
May 30, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 30, 2022

Description
If a user updates CI on production server, assert() may not work.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label May 30, 2022
@samsonasik samsonasik mentioned this pull request May 30, 2022
Closed
1 task
@kenjis kenjis merged commit e09a5fe into codeigniter4:develop May 30, 2022
@kenjis kenjis deleted the fix-codeigniter-context-check branch May 30, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik