Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FrameworkException instead of assert on missing context on CodeIgniter::run() #6048

Closed
wants to merge 1 commit into from
Closed

Use FrameworkException instead of assert on missing context on CodeIgniter::run() #6048

wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

@paulbalandan @kenjis based on our discussion on on slack, this PR update assert() usage to FrameworkException for missing context in CodeIgniter::run().

Before

Screen Shot 2022-05-30 at 09 08 39

After

Screen Shot 2022-05-30 at 09 10 30

Checklist:

  • Securely signed commits

@samsonasik samsonasik requested review from kenjis and paulbalandan May 30, 2022 02:11
@samsonasik
Copy link
Member Author

@kenjis oops, just check your PR #6047. I am closing it then.

@samsonasik samsonasik closed this May 30, 2022
@samsonasik samsonasik deleted the add-frameworkexception-formissingcontext branch May 30, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis Awaiting requested review from kenjis

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik