Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BaseConnection may create dynamic property #6198

Merged
merged 3 commits into from
Jul 1, 2022
Merged

fix: BaseConnection may create dynamic property #6198

merged 3 commits into from
Jul 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 29, 2022 •
edited
Loading

Description
See #6162 (comment)

  • do not create dynamic property in BaseConnection

The current database tests group is for SQLite3 that has foreignKeys property.

CodeIgniter4/app/Config/Database.php

Line 77 in 24f67ea

'foreignKeys' => true,

If a user overrides DBDriver, the dynamic property foreignKeys will be created.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 29, 2022
@kenjis kenjis mentioned this pull request Jun 29, 2022
Closed
7 tasks
MGatner
MGatner approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there would be more properties that needed declaring but the tests look good so I guess not.

@kenjis kenjis merged commit 397c606 into codeigniter4:develop Jul 1, 2022
@kenjis kenjis deleted the fix-dynamic-property-in-BaseConnection branch July 1, 2022 07:50
@kenjis kenjis added the PHP 8.2 label Oct 12, 2022
@kenjis kenjis removed the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner