Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: PHP 8.2 support #6170

Closed
7 tasks done
kenjis opened this issue Jun 21, 2022 · 3 comments
Closed
7 tasks done

Dev: PHP 8.2 support #6170

kenjis opened this issue Jun 21, 2022 · 3 comments
Labels
dev help wanted More help is needed for the proper resolution of an issue or pull request

Comments

@kenjis
Copy link
Member

kenjis commented Jun 21, 2022

https://wiki.php.net/todo/php82

References:

@paulbalandan
Copy link
Member

@kenjis can this be closed? or are we still waiting for the last two tickets to clear?

@kenjis
Copy link
Member Author

kenjis commented Nov 10, 2022

I'm not sure.
Probably we do not use deprecate_partially_supported_callables.
I did not check the impact of strtolower-ascii.

@kenjis
Copy link
Member Author

kenjis commented Nov 14, 2022

About PHP: rfc:strtolower-ascii.

I've checked strtolower() in develop.

Many parts of the code look fine.

PHP 8.0 stopped respecting the locale environment variables. So the locale is always “C” unless the user explicitly calls setlocale().
https://wiki.php.net/rfc/strtolower-ascii

CI4 does not call setlocale(). So in PHP8 this PHP 8.2 change has nothing to do with (unless users don't call setlocale()).

From the above, it seems that there is no major problem.
If an problem is found, we would like to address it as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev help wanted More help is needed for the proper resolution of an issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants