Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix Creation of dynamic property error in PHP 8.2 #6757

Merged
merged 1 commit into from
Oct 26, 2022
Merged

test: fix Creation of dynamic property error in PHP 8.2 #6757

merged 1 commit into from
Oct 26, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 26, 2022

Description
See #6170

1) CodeIgniter\Database\Live\GetTest::testGetRowWithCustomReturnType
ErrorException: Creation of dynamic property class@anonymous::$id is deprecated

/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/SQLite3/Result.php:143
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/SQLite3/Result.php:147
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/BaseResult.php:149
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/BaseResult.php:286
/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Database/BaseResult.php:273
/Users/kenji/work/codeigniter/official/CodeIgniter4/tests/system/Database/Live/GetTest.php:234

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
test: fix Creation of dynamic property error
05ceae4 
ErrorException: Creation of dynamic property class@anonymous::$id is deprecated
@kenjis kenjis added testing Pull requests that changes tests only PHP 8.2 labels Oct 26, 2022
@kenjis kenjis mentioned this pull request Oct 26, 2022
Closed
7 tasks
@kenjis kenjis merged commit da2eabc into codeigniter4:develop Oct 26, 2022
@kenjis kenjis deleted the fix-test-php82-Database-GetTest branch October 26, 2022 07:35
@kenjis kenjis mentioned this pull request Oct 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan