Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove Registrar tests for dynamic property #6586

Merged
merged 1 commit into from
Sep 25, 2022
Merged

test: remove Registrar tests for dynamic property #6586

merged 1 commit into from
Sep 25, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 25, 2022

Description

  • remove tests for dynamic property

See #6162

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
fix: remove tests for dynamic properties
6fa6534 
We do not use dynamic properties.
@kenjis kenjis added the testing Pull requests that changes tests only label Sep 25, 2022
@kenjis kenjis mentioned this pull request Sep 25, 2022
Closed
7 tasks
@kenjis kenjis changed the title fix: remove Registrar tests for dynamic property test: remove Registrar tests for dynamic property Sep 25, 2022
MGatner
MGatner approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis kenjis merged commit 6da8898 into codeigniter4:develop Sep 25, 2022
@kenjis kenjis deleted the fix-dynamic-properties branch September 25, 2022 10:56
@kenjis kenjis added the PHP 8.2 label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner