Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer/nav routing Update Events routing & add Privacy Policy routing #1136

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Shane-Donlon
Copy link
Contributor

✨ Codu Pull Request πŸ’»

Fixes #(issue)
#1134 & #1135

2 minor changes to sites_settings.ts file.

Pull Request details

  • INFO ABOUT YOUR PULL REQUEST GOES HERE (Please be as descriptive as possible) 🀜
  • Routing for Events (meetup page ) in footer nav had preceding / causing a codu.co URL prefix.
  • Privacy Policy /privacy routing has been added.

Any Breaking changes

None

Associated Screenshots

None.

@Shane-Donlon Shane-Donlon requested a review from a team as a code owner October 16, 2024 15:41
Copy link

vercel bot commented Oct 16, 2024

@Shane-Donlon is attempting to deploy a commit to the CodΓΊ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

Walkthrough

The changes involve modifications to the footerNav and navigation arrays in the config/site_settings.ts file. The "Events" entry's href value has been corrected from a relative URL to an absolute URL. Additionally, a new entry for "Privacy Policy" has been added to the footerNav array. The navigation array has also been updated to reflect the corrected absolute URL for the "Events" entry.

Changes

File Change Summary
config/site_settings.ts - Updated footerNav to include a new entry: { name: "Privacy Policy", href: "/privacy" }
- Changed href for "Events" in footerNav from a relative URL to an absolute URL
- Updated href for "Events" in navigation to match the absolute URL

Suggested reviewers

  • NiallJoeMaher

Poem

πŸ‡ In the footer where we play,
Links now lead the right way,
Privacy joins the happy crew,
Events shine bright, all brand new!
Hops and clicks, a joyful spree,
Navigate with glee, oh, hop with me! 🌟


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

πŸ“₯ Commits

Files that changed from the base of the PR and between 4c064e9 and 9f442d2.

πŸ“’ Files selected for processing (1)
  • config/site_settings.ts (1 hunks)
🧰 Additional context used
πŸ”‡ Additional comments (3)
config/site_settings.ts (3)

4-4: LGTM: Events link correctly updated

The href for the "Events" entry has been properly updated to use an absolute URL. This change aligns with the PR objectives and resolves the routing issue by removing the leading slash that was causing the URL to be prefixed with "codu.co".


Line range hint 1-30: LGTM: Consistent changes across the file

The changes made to the "Events" href are consistent in both the footerNav and navigation arrays. The rest of the file remains unchanged, which is appropriate for the scope of this PR.


7-7: LGTM: Privacy Policy link added

The new "Privacy Policy" entry has been correctly added to the footerNav array with the appropriate href. This addition aligns with the PR objectives.

Please ensure that the "/privacy" route exists or will be created as part of this change. Run the following script to check for the existence of a Privacy Policy page or route:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@John-Paul-Larkin John-Paul-Larkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught the bug now @Shane-Donlon

@NiallJoeMaher NiallJoeMaher merged commit f8c9145 into codu-code:develop Oct 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants