Ability to embed YouTube videos in markdown #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@GitHub-Harrison is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
GitHub-Harrison
requested review from
pkspyder007 and
NiallJoeMaher
as code owners
|
I’m going to have to wait until @gdomaradzki or @pkspyder007 gets to manually test this one to confirm things are as expected. Looks good from the code but I don’t have my laptop for a few days. 🦾 |
|
Based on our discussions in Discord, we are going to evaluate a different solution so that YouTube videos can be embedded and played directly from an article rather than redirecting to YouTube. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Codu Pull Request 💻
Pull Request details:
Created a new markdown file content/articles/embed-yt-videos.md, within this file I used markdown syntax to allow for youtube videos to be shown alongside a comment explaining how it works. I've used this syntax on most of my Code Institute projects with no issues.
The test video just has a placeholder thumbnail but can be customised with any image or screenshot. You can also have it just as a text hyperlink if desired.
I was unable to test on the site due to a server 500 error but I am confident that this should work as I've used it on multiple projects and it displays perfectly fine on GitHub.
Any Breaking changes:
Associated Screenshots: