Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tag retrieval in ArticlesPage component to Drizzle #835

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

NiallJoeMaher
Copy link
Contributor

@NiallJoeMaher NiallJoeMaher commented Mar 14, 2024

✨ Codu Pull Request 💻

Codu Logo

Pull Request details

  • Refactor fetching of tags to Drizzle
  • Remove input option to the tags

Any Breaking changes

  • None (I hope)

Summary by CodeRabbit

  • New Features
    • Enhanced tag display logic on the Articles Page to improve user experience.
  • Bug Fixes
    • Fixed an issue with tag data fetching to ensure more reliable and relevant tag displays.
  • Refactor
    • Updated backend query structure for fetching tag data to optimize performance.

@NiallJoeMaher NiallJoeMaher requested a review from a team as a code owner March 14, 2024 13:28
Copy link

vercel bot commented Mar 14, 2024

@NiallJoeMaher is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Walkthrough

The recent update involves modifications across the application and server layers, focusing on simplifying the useQuery usage in the articles component, refining data fetching for tags with a new ORM strategy, and enforcing a notNull constraint on the tag table's title field. This overhaul enhances data handling, streamlines tag-related operations, and ensures data integrity by mandating titles for tags.

Changes

Files Change Summary
app/.../_client.tsx Updated useQuery usage, adjusted tag data mapping to use title, changed keys and href values in mapping, and modified function calls to use title instead of tag.title.
server/api/router/tag.ts Switched to drizzle-orm for fetching tag data with a new query structure, including selection, grouping, left join, limiting, and ordering operations.
server/db/schema.ts Modified the title field in the tag table to be notNull, ensuring data integrity.

🐰✨

In the realm of code, where changes abound,
A rabbit hopped in, its purpose profound.
To tweak and to twirl, with a magical touch,
Ensuring the tags, now mean so much.
With titles so bold, and queries so neat,
Our data now dances, oh what a feat!
🌟📝🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 1:31pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c870ede and 8f62eda.
Files selected for processing (3)
  • app/(app)/articles/_client.tsx (3 hunks)
  • server/api/router/tag.ts (1 hunks)
  • server/db/schema.ts (1 hunks)
Additional comments: 6
server/api/router/tag.ts (2)
  • 9-18: The query construction for fetching tag data using drizzle-orm is well-implemented, correctly utilizing methods like count, groupBy, leftJoin, limit, and orderBy to achieve the desired functionality.
  • 1-23: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [20-26]

The error handling mechanism is correctly implemented, ensuring that any exceptions during the query execution are caught and a meaningful TRPCError is thrown. This is a good practice for providing clear error feedback to the client.

app/(app)/articles/_client.tsx (3)
  • 51-51: The adjustment to call the useQuery hook without parameters aligns with the refactor objectives and simplifies the tag fetching mechanism.
  • 189-196: The changes to the mapping of tagsData, including the direct destructuring of the title property and its use in key and href values, simplify data handling and improve code readability.
  • 189-196: The use of the title property in lowercase for href values and as the key for mapped elements enhances URL aesthetics and ensures unique keys for React elements, aligning with the PR objectives.
server/db/schema.ts (1)
  • 83-83: Making the title field non-nullable in the tag table declaration is a best practice for database design, enhancing data integrity and consistency across the platform.

@NiallJoeMaher NiallJoeMaher merged commit 5bcb565 into codu-code:develop Mar 14, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant