-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): use babel-runtime
is a dependency
(dependencies
)
#312
Conversation
|
babel-runtime
is a dependency
(dependencies
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickpape-msft Thx
Released in |
😱 @nickpape-msft Please sign the CLA or I need to revert this |
I work at a large company, it will likely take weeks to sign the CLA, but I started the approval process. Perhaps we want to revert and then have someone who has signed the CLA to clean-room this change. |
@michael-ciniawsky will you revert the change? I would like to know, since we locked the dependency version to |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
lib/karma-webpack.js
has the following line:When using
pnpm
, the babel-runtime is marked as a devDependency and therefore not included in thenode_modules
. Hence you get the following error:What is the new behavior?
The
babel-runtime
is installed as a runtime dependency.Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: