Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin karma-webpack to 3.0.9 #544

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Pin karma-webpack to 3.0.9 #544

merged 2 commits into from
Feb 27, 2018

Conversation

nickpape
Copy link
Contributor

3.0.12 has missing dependencies in it's package.json (on babel-runtime), which is causing pnpm installations to fail. Since we are deprecating karma, the easiest fix is to simply pin karma-webpack to a working version.

@iclanton
Copy link
Member

iclanton commented Feb 27, 2018

Approved.

Approved with PullApprove

@octogonz
Copy link
Collaborator

octogonz commented Feb 27, 2018

:shipit:

Approved with PullApprove

@octogonz octogonz merged commit fdc2cd6 into master Feb 27, 2018
@nickpape nickpape deleted the nickpape/pin-karma-webpack branch March 2, 2018 23:50
@nickpape
Copy link
Contributor Author

nickpape commented Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants