fix: clearing wrong render target #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christjt
added
auto-update
Codecov Report
@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
- Coverage 71.23% 71.21% -0.03%
==========================================
Files 259 259
Lines 10789 10788 -1
Branches 1364 1364
==========================================
- Hits 7686 7683 -3
- Misses 2950 2952 +2
Partials 153 153
|
pramodcog
approved these changes
May 27, 2022
haakonflatval-cognite
added a commit
that referenced
this pull request
May 30, 2022
* chore(deps): update dependency @cognite/sdk to v7.4.0 (#2160) Co-authored-by: Renovate Bot <bot@renovateapp.com> * improvement: remove unused 'headers' for custom data sources and update docs (#2164) * fix: clearing wrong render target (#2166) * example: add UI for setting point size type (#2157) * improvement: Make typescript strict (#2163) * fix: fix all strict typechecking errors * improvement: don't return primitive collections if empty * chore: lint fix * improvement: make byteOffset 0 if undefined * improvement: unhackify helper function * fix: fix that byteOffset fix * fix: fix type errors for tests * fix: correct BinaryHeap bevaviour Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.5.0 (#2165) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * feat: simple styling in the works * feat: working visualization of pipe system Pipe data not included * feat: add simple styling interface for point clouds Also temporarily add data.ts to allow for testing for people who are not me * refac: make object style LUT 2D * refactor: let EPT loader take non-hardcoded object list * feat: automatically fetch annotations from server on point cloud load * chore: update Migration example for annotation fetching * fix: remove unused import * fix: remove not-yet-available feature * feat: add arbitrarily oriented boxes as stylable objects * refactor: some cleanup among stylable shapes * fix: don't import anything externally to worker * chore: lint fix * feat: blend style color with original RGB * chore: lint fix * chore: fix LGTM warnings * chore: update yarn lock * test: fix constructor in test * chore: remove unused member variable * chore: remove unused import Fixes LGTM error * fix: make @cognite/sdk-playground a peer dependency * fix: fix that pesky visual test error * refactor: factor out default EPT metadata file name * improvement: make "then" into an "await" * refactor: refactor annotation translation * chore: make public variable private-gettable * fix: correct import path * fix: refer to private field, not public getter * refactor: rewrite point cloud buffer parsing * improvement: be stricter in specifying optional types * improvement: make use of color constants * improvement: rewrite 0-vector check * fix: correct paratheses in shader * improvement: mappify array transformation * improvement: make ShapeType an enum * improvement: remove out-commented import * chore: lint fix * fix: make CogniteClientPlayground optionality annotation stricter * test: add trivial test for CognitePointCloudModel * fix: add missing creation function file * refactor: move some responsibility from PointCloudManager to -Factory * improvement: then -> await * fix: make indices be of type Uint32 * feat: add fromThreeVector3 utility function * refactor: parser-worker logic * improvement: make parse(data) actually return parsed data * improvement: improve readability * refactor: simplify primitive translation * improvement: renamed/simplify objectId assignment * refactor: change terminology from "StyledObject" to "StylableObject" * refactor: simplify Box constructor * chore: minor cleanup * improvement: simplify composite bounding box computation * fix: correct Box constructor call * fix: repair, please type checker, and lint after merge * improvement: remove computeBoundingBox for shapes for now They'll be back for the acceleration structure * chore: another lint fix * chore: add warning regarding point-object matching * refactor: remove "StylableObjectInfo" abstraction * chore: lint fix Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
haakonflatval-cognite
added a commit
that referenced
this pull request
Jun 14, 2022
* chore(deps): update dependency @cognite/sdk to v7.4.0 (#2160) Co-authored-by: Renovate Bot <bot@renovateapp.com> * improvement: remove unused 'headers' for custom data sources and update docs (#2164) * fix: clearing wrong render target (#2166) * example: add UI for setting point size type (#2157) * improvement: Make typescript strict (#2163) * fix: fix all strict typechecking errors * improvement: don't return primitive collections if empty * chore: lint fix * improvement: make byteOffset 0 if undefined * improvement: unhackify helper function * fix: fix that byteOffset fix * fix: fix type errors for tests * fix: correct BinaryHeap bevaviour Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.5.0 (#2165) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * feat: simple styling in the works * feat: working visualization of pipe system Pipe data not included * feat: add simple styling interface for point clouds Also temporarily add data.ts to allow for testing for people who are not me * refac: make object style LUT 2D * refactor: let EPT loader take non-hardcoded object list * feat: automatically fetch annotations from server on point cloud load * chore: update Migration example for annotation fetching * fix: remove unused import * fix: remove not-yet-available feature * feat: add arbitrarily oriented boxes as stylable objects * refactor: some cleanup among stylable shapes * fix: don't import anything externally to worker * chore: lint fix * feat: blend style color with original RGB * chore: lint fix * chore: fix LGTM warnings * chore: update yarn lock * test: fix constructor in test * chore: remove unused member variable * chore: remove unused import Fixes LGTM error * fix: make @cognite/sdk-playground a peer dependency * fix: fix that pesky visual test error * refactor: factor out default EPT metadata file name * improvement: make "then" into an "await" * refactor: refactor annotation translation * chore: make public variable private-gettable * fix: correct import path * fix: refer to private field, not public getter * refactor: rewrite point cloud buffer parsing * improvement: be stricter in specifying optional types * improvement: make use of color constants * improvement: rewrite 0-vector check * fix: correct paratheses in shader * improvement: mappify array transformation * improvement: make ShapeType an enum * improvement: remove out-commented import * chore: lint fix * fix: make CogniteClientPlayground optionality annotation stricter * test: add trivial test for CognitePointCloudModel * fix: add missing creation function file * refactor: move some responsibility from PointCloudManager to -Factory * improvement: then -> await * fix: make indices be of type Uint32 * feat: add fromThreeVector3 utility function * refactor: parser-worker logic * improvement: make parse(data) actually return parsed data * improvement: improve readability * refactor: simplify primitive translation * improvement: renamed/simplify objectId assignment * refactor: change terminology from "StyledObject" to "StylableObject" * refactor: simplify Box constructor * chore: minor cleanup * improvement: simplify composite bounding box computation * fix: correct Box constructor call * fix: repair, please type checker, and lint after merge * improvement: remove computeBoundingBox for shapes for now They'll be back for the acceleration structure * chore: another lint fix * chore: add warning regarding point-object matching * refactor: remove "StylableObjectInfo" abstraction * chore: lint fix Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
Savokr
pushed a commit
that referenced
this pull request
Jun 21, 2022
* chore(deps): update dependency @cognite/sdk to v7.4.0 (#2160) Co-authored-by: Renovate Bot <bot@renovateapp.com> * improvement: remove unused 'headers' for custom data sources and update docs (#2164) * fix: clearing wrong render target (#2166) * example: add UI for setting point size type (#2157) * improvement: Make typescript strict (#2163) * fix: fix all strict typechecking errors * improvement: don't return primitive collections if empty * chore: lint fix * improvement: make byteOffset 0 if undefined * improvement: unhackify helper function * fix: fix that byteOffset fix * fix: fix type errors for tests * fix: correct BinaryHeap bevaviour Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.5.0 (#2165) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * feat: simple styling in the works * feat: working visualization of pipe system Pipe data not included * feat: add simple styling interface for point clouds Also temporarily add data.ts to allow for testing for people who are not me * refac: make object style LUT 2D * refactor: let EPT loader take non-hardcoded object list * feat: automatically fetch annotations from server on point cloud load * chore: update Migration example for annotation fetching * fix: remove unused import * fix: remove not-yet-available feature * feat: add arbitrarily oriented boxes as stylable objects * refactor: some cleanup among stylable shapes * fix: don't import anything externally to worker * chore: lint fix * feat: blend style color with original RGB * chore: lint fix * chore: fix LGTM warnings * chore: update yarn lock * test: fix constructor in test * chore: remove unused member variable * chore: remove unused import Fixes LGTM error * fix: make @cognite/sdk-playground a peer dependency * fix: fix that pesky visual test error * refactor: factor out default EPT metadata file name * improvement: make "then" into an "await" * refactor: refactor annotation translation * chore: make public variable private-gettable * fix: correct import path * fix: refer to private field, not public getter * refactor: rewrite point cloud buffer parsing * improvement: be stricter in specifying optional types * improvement: make use of color constants * improvement: rewrite 0-vector check * fix: correct paratheses in shader * improvement: mappify array transformation * improvement: make ShapeType an enum * improvement: remove out-commented import * chore: lint fix * fix: make CogniteClientPlayground optionality annotation stricter * test: add trivial test for CognitePointCloudModel * fix: add missing creation function file * refactor: move some responsibility from PointCloudManager to -Factory * improvement: then -> await * fix: make indices be of type Uint32 * feat: add fromThreeVector3 utility function * refactor: parser-worker logic * improvement: make parse(data) actually return parsed data * improvement: improve readability * refactor: simplify primitive translation * improvement: renamed/simplify objectId assignment * refactor: change terminology from "StyledObject" to "StylableObject" * refactor: simplify Box constructor * chore: minor cleanup * improvement: simplify composite bounding box computation * fix: correct Box constructor call * fix: repair, please type checker, and lint after merge * improvement: remove computeBoundingBox for shapes for now They'll be back for the acceleration structure * chore: another lint fix * chore: add warning regarding point-object matching * refactor: remove "StylableObjectInfo" abstraction * chore: lint fix Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "white screen" issue when picking / mouse scrolling