-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: speed up point-object assignment with a bounding volume hierarchy #2270
feat: speed up point-object assignment with a bounding volume hierarchy #2270
Conversation
This pull request introduces 1 alert when merging 4f4bc0b into 0b2c2aa - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e539df4 into 60a80e3 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## feat/point-cloud-styling #2270 +/- ##
============================================================
+ Coverage 70.37% 70.58% +0.20%
============================================================
Files 271 283 +12
Lines 11072 11387 +315
Branches 1405 1475 +70
============================================================
+ Hits 7792 8037 +245
- Misses 3123 3177 +54
- Partials 157 173 +16
|
60a80e3
to
a3cfbb3
Compare
fee66b3
to
a14ccf5
Compare
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
Change description of PR to describe what we achieve (it's currently how ;) ) |
This pull request introduces 1 alert when merging d5ccdc0 into a3cfbb3 - view on LGTM.com new alerts:
|
NB: Splits the webpack config to avoid bundling ThreeJS in more than one output. Further investigation required to figure out how to not bundle ThreeJS at all
NB: Very untested
Introducing temporary variables and cached fields to avoid unnecessary allocations
Investigated as an alternative to BVH
Means more objects, but more precise bounding boxes
b9b6a81
to
16a279d
Compare
This pull request introduces 5 alerts when merging 16a279d into 1ce4078 - view on LGTM.com new alerts:
|
We have arrived at the conclusion that we want this merged into the feature branch now. It is not as good as we would want, but it provides an enormous improvement over the previous approach. That being said, there is quite a bit of garbage lying around. The BVH implementation is unused and the octree is tested. A lot of superfluous out-commented lines are still in |
Just to make it clear here, this PR is intended to be superseded by #2327 , and will be closed as soon that one is merged. |
Closing, as it is superseded by #2327 |
Description
Note: This PR is superseded by #2327 and will likely be deleted.
Speeds up the point-object matching process by using a Bounding Volume Hierarchy (BVH). It improves the loading/ point-object matching time for the root sector of the point cloud from ~35s to 1-2s.
Further suggestions for performance improvements are given in a JIRA issue.
This PR also fixes an issue where box matrices from the backend where not interpreted in row-major order as they should.
This PR currently targets the branch for workers in libraries, which it depends on. It should eventually target and be merged into the point cloud feature branch.
Further work: Tests
Checklist:
Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.