-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rust/Webassembly octree implementation for faster point-object assignment #2327
feat: Rust/Webassembly octree implementation for faster point-object assignment #2327
Conversation
This pull request introduces 1 alert when merging b887b82 into 63118d1 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ec09ed3 into 63118d1 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging bef073f into 63118d1 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 776541a into 63118d1 - view on LGTM.com new alerts:
|
6947e9c
to
37ab054
Compare
4f0eaa0
to
fb3fe4b
Compare
42e4145
to
da1076e
Compare
There were failures in the Visual regression tests workflow. |
There were failures in the Visual regression tests workflow. |
There were failures in the Visual regression tests workflow. |
Codecov Report
@@ Coverage Diff @@
## feat/point-cloud-styling #2327 +/- ##
============================================================
- Coverage 70.37% 68.89% -1.49%
============================================================
Files 271 258 -13
Lines 11072 11193 +121
Branches 1405 1450 +45
============================================================
- Hits 7792 7711 -81
- Misses 3123 3308 +185
- Partials 157 174 +17
|
There were failures in the Visual regression tests workflow. |
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
There were failures in the Visual regression tests workflow. |
There were failures in the Visual regression tests workflow. |
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
There were failures in the Visual regression tests workflow. |
21a6326
to
913b558
Compare
There were failures in the visual tests workflow. |
There were failures in the visual tests workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me now. Some minor stuff I've added, but I am accepting the PR under the assumption you address these. Look forward to seeing it in action!
viewer/packages/pointclouds/src/potree-three-loader/workers/assignPointsWithWasm.ts
Outdated
Show resolved
Hide resolved
* feat: Add ability to style objects in point clouds (#2104) * feat: point cloud API for styling (#2179) * feat: Webassembly setup (#2353) * Update point cloud feature branch from master (#2416) * feat: Rust/Webassembly octree implementation for faster point-object assignment (#2327) * feat: custom classification (#2320) * docs: finalize point cloud styling docs (#2500) * refactor: move point cloud object provider to data-providers and expose object bounding boxes (#2522) * fix: point cloud custom transformation (#2550) * improvement: various fixes for point clouds (#2551) * fix: export point cloud object metadata (#2552) * Various big and small fixes Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>
Description
An attempt at creating a faster octree for point-object assignment using Rust/Webassembly.
Checklist:
Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.