-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: various fixes for point clouds #2551
Merged
haakonflatval-cognite
merged 4 commits into
feat/point-cloud-styling
from
hflatval/point-cloud-various-fixes
Oct 10, 2022
Merged
improvement: various fixes for point clouds #2551
haakonflatval-cognite
merged 4 commits into
feat/point-cloud-styling
from
hflatval/point-cloud-various-fixes
Oct 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
added
the
slack
PRs and issues with this label will be pushed to Slack
label
Oct 10, 2022
Crash occured if more than one point cloud model was added
haakonflatval-cognite
force-pushed
the
hflatval/point-cloud-various-fixes
branch
from
October 10, 2022 13:16
b735bbc
to
1201d5e
Compare
Codecov Report
@@ Coverage Diff @@
## feat/point-cloud-styling #2551 +/- ##
============================================================
- Coverage 70.37% 68.34% -2.03%
============================================================
Files 271 239 -32
Lines 11072 9715 -1357
Branches 1405 1274 -131
============================================================
- Hits 7792 6640 -1152
+ Misses 3123 2917 -206
- Partials 157 158 +1
|
christjt
approved these changes
Oct 10, 2022
haakonflatval-cognite
added a commit
that referenced
this pull request
Oct 11, 2022
* fix: avoid GUI folder name collision in Viewer Crash occured if more than one point cloud model was added * fix: remove unnecessary child-parent assignment * fix: typo in ModelUi * chore: update yarn lock
haakonflatval-cognite
added a commit
that referenced
this pull request
Oct 14, 2022
* fix: avoid GUI folder name collision in Viewer Crash occured if more than one point cloud model was added * fix: remove unnecessary child-parent assignment * fix: typo in ModelUi * chore: update yarn lock
haakonflatval-cognite
added a commit
that referenced
this pull request
Oct 18, 2022
* feat: Add ability to style objects in point clouds (#2104) * feat: point cloud API for styling (#2179) * feat: Webassembly setup (#2353) * Update point cloud feature branch from master (#2416) * feat: Rust/Webassembly octree implementation for faster point-object assignment (#2327) * feat: custom classification (#2320) * docs: finalize point cloud styling docs (#2500) * refactor: move point cloud object provider to data-providers and expose object bounding boxes (#2522) * fix: point cloud custom transformation (#2550) * improvement: various fixes for point clouds (#2551) * fix: export point cloud object metadata (#2552) * Various big and small fixes Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of fixes for point clouds that I deemed too small for their own PRs
Checklist:
Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.