feat: point cloud styling #2569

haakonflatval-cognite · 2022-10-14T13:47:43Z

Description

The point cloud styling feature branch has come to an end.

Virtually all changes here have already been reviewed, but extra care should be taken to make sure nothing has been deleted in the intermediate merges throughout the history of this long-lived branch.

Main features:

Point cloud styling
- Classes for point cloud object shapes
- Classes for point cloud object collections
- Classes for point cloud appearance
- Automatic loading and parsing of point cloud objects from the annotations API on model load
A new Webassembly setup
- Workspace setup
- CI setup
- Example implementation (the point-object matching algorithm) in the pointclouds package
Custom point cloud classification
- Allows for users to specify a classificationSets.json together with model output
- Opens for custom class names and colors

Models for testing

Areas with stylable point cloud objects:
https://localhost:3000/migration?env=greenfield-3d&project=3d-test&modelId=585243814592633&revisionId=3257698523483861

One tile with custom classification:
https://localhost:3000/?project=3d-test&env=greenfield-3d&modelId=8469230628558008&revisionId=7343065242395381

Checklist:

Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.

* chore(deps): update dependency @cognite/sdk to v7.4.0 (#2160) Co-authored-by: Renovate Bot <bot@renovateapp.com> * improvement: remove unused 'headers' for custom data sources and update docs (#2164) * fix: clearing wrong render target (#2166) * example: add UI for setting point size type (#2157) * improvement: Make typescript strict (#2163) * fix: fix all strict typechecking errors * improvement: don't return primitive collections if empty * chore: lint fix * improvement: make byteOffset 0 if undefined * improvement: unhackify helper function * fix: fix that byteOffset fix * fix: fix type errors for tests * fix: correct BinaryHeap bevaviour Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.5.0 (#2165) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * feat: simple styling in the works * feat: working visualization of pipe system Pipe data not included * feat: add simple styling interface for point clouds Also temporarily add data.ts to allow for testing for people who are not me * refac: make object style LUT 2D * refactor: let EPT loader take non-hardcoded object list * feat: automatically fetch annotations from server on point cloud load * chore: update Migration example for annotation fetching * fix: remove unused import * fix: remove not-yet-available feature * feat: add arbitrarily oriented boxes as stylable objects * refactor: some cleanup among stylable shapes * fix: don't import anything externally to worker * chore: lint fix * feat: blend style color with original RGB * chore: lint fix * chore: fix LGTM warnings * chore: update yarn lock * test: fix constructor in test * chore: remove unused member variable * chore: remove unused import Fixes LGTM error * fix: make @cognite/sdk-playground a peer dependency * fix: fix that pesky visual test error * refactor: factor out default EPT metadata file name * improvement: make "then" into an "await" * refactor: refactor annotation translation * chore: make public variable private-gettable * fix: correct import path * fix: refer to private field, not public getter * refactor: rewrite point cloud buffer parsing * improvement: be stricter in specifying optional types * improvement: make use of color constants * improvement: rewrite 0-vector check * fix: correct paratheses in shader * improvement: mappify array transformation * improvement: make ShapeType an enum * improvement: remove out-commented import * chore: lint fix * fix: make CogniteClientPlayground optionality annotation stricter * test: add trivial test for CognitePointCloudModel * fix: add missing creation function file * refactor: move some responsibility from PointCloudManager to -Factory * improvement: then -> await * fix: make indices be of type Uint32 * feat: add fromThreeVector3 utility function * refactor: parser-worker logic * improvement: make parse(data) actually return parsed data * improvement: improve readability * refactor: simplify primitive translation * improvement: renamed/simplify objectId assignment * refactor: change terminology from "StyledObject" to "StylableObject" * refactor: simplify Box constructor * chore: minor cleanup * improvement: simplify composite bounding box computation * fix: correct Box constructor call * fix: repair, please type checker, and lint after merge * improvement: remove computeBoundingBox for shapes for now They'll be back for the acceleration structure * chore: another lint fix * chore: add warning regarding point-object matching * refactor: remove "StylableObjectInfo" abstraction * chore: lint fix Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @cognite/sdk to v7.4.0 (#2160) Co-authored-by: Renovate Bot <bot@renovateapp.com> * improvement: remove unused 'headers' for custom data sources and update docs (#2164) * fix: clearing wrong render target (#2166) * example: add UI for setting point size type (#2157) * improvement: Make typescript strict (#2163) * fix: fix all strict typechecking errors * improvement: don't return primitive collections if empty * chore: lint fix * improvement: make byteOffset 0 if undefined * improvement: unhackify helper function * fix: fix that byteOffset fix * fix: fix type errors for tests * fix: correct BinaryHeap bevaviour Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.5.0 (#2165) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * feat: simple styling in the works * feat: working visualization of pipe system Pipe data not included * feat: add simple styling interface for point clouds Also temporarily add data.ts to allow for testing for people who are not me * refac: make object style LUT 2D * refactor: let EPT loader take non-hardcoded object list * feat: automatically fetch annotations from server on point cloud load * chore: update Migration example for annotation fetching * fix: remove unused import * fix: remove not-yet-available feature * feat: add arbitrarily oriented boxes as stylable objects * refactor: some cleanup among stylable shapes * fix: don't import anything externally to worker * chore: lint fix * feat: blend style color with original RGB * chore: lint fix * chore: fix LGTM warnings * chore: update yarn lock * test: fix constructor in test * chore: remove unused member variable * chore: remove unused import Fixes LGTM error * fix: make @cognite/sdk-playground a peer dependency * fix: fix that pesky visual test error * refactor: factor out default EPT metadata file name * improvement: make "then" into an "await" * refactor: refactor annotation translation * chore: make public variable private-gettable * fix: correct import path * fix: refer to private field, not public getter * refactor: rewrite point cloud buffer parsing * improvement: be stricter in specifying optional types * improvement: make use of color constants * improvement: rewrite 0-vector check * fix: correct paratheses in shader * improvement: mappify array transformation * improvement: make ShapeType an enum * improvement: remove out-commented import * chore: lint fix * fix: make CogniteClientPlayground optionality annotation stricter * test: add trivial test for CognitePointCloudModel * fix: add missing creation function file * refactor: move some responsibility from PointCloudManager to -Factory * improvement: then -> await * fix: make indices be of type Uint32 * feat: add fromThreeVector3 utility function * refactor: parser-worker logic * improvement: make parse(data) actually return parsed data * improvement: improve readability * refactor: simplify primitive translation * improvement: renamed/simplify objectId assignment * refactor: change terminology from "StyledObject" to "StylableObject" * refactor: simplify Box constructor * chore: minor cleanup * improvement: simplify composite bounding box computation * fix: correct Box constructor call * fix: repair, please type checker, and lint after merge * improvement: remove computeBoundingBox for shapes for now They'll be back for the acceleration structure * chore: another lint fix * chore: add warning regarding point-object matching * refactor: remove "StylableObjectInfo" abstraction * chore: lint fix Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

…data/reveal into feat/point-cloud-styling

… master rebase (#2233) Fixed errors after rebase

* chore: bump reveal version 3.x doc (#2231) * chore: bump reveal version 3.x doc * Updated 3.x docs Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2162) * fix(deps): update dependency three to v0.141.0 * fix: undo documentation three bump * chore: bump three for examples Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com> * refactor: port core package to api package (#2192) * chore: move file type mocks to test utilities * refactor: remove unused types * refactor: move all internal export to root * refactor: port core to new api package * fix: restore build * fix: ignore typing error from geomap * fix: restore tests Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * improvement: avoid stalling rendering by adding asynchronous picking (#2191) * fix: backport threejs for documentation to fix v1 doc (#2237) * chore(deps): update dependency gl to v5.0.3 (#2238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * test: added test for Cognite3dViewer.dispose() (#2141) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * improvement: hide/show HTML overlay elements (#2240) * Added API to show/hide HTMLOverlay elements Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v13.0.3 (#2241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: mobile default settings should not include ssao, add iPad fix (#2239) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: in-front objects incorrectly blending with background (#2248) * fix: in-front objects now incorrectly blending * chore: update visual tests * chore: bump to Webpack 5 (#2244) * feat: migrate examples to webpack-5 * improvement: simplify and de-deprecate config-overrides * feat: upgrade to webpack 5 in viewer * fix: correct watchOptions.ignored field * fix: visual tests in examples * feat: update webpack config for example apps * chore: add temporary entrypoint+dependency in webpack conf * fix: make examples correctly pick up three js * fix: replace react-rewired stuff with own wepback config * improvement: add log of which visual test is running * fix: use better OpenGL backend in puppeteer * test: update visual test images * fix: fix test images after updating GPU backend * improvement: simplify viewer webpack config * chore: lint fix * fix: add environment variable for production build * feat: also serve content from examples/public * fix: try backporting pupeteer webgl backend for fixing CI tests * chore: attempt to build reveal in prod for documentation * chore: remove unused variable and update label * chore: update documentation yarn.lock * fix: restore tests from wrong merge * fix: update visual tests after merge... again... Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com> * chore(deps): update dependency ts-loader to v9.3.1 (#2249) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency core-js to v3.23.3 (#2243) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: improper linking of viewer into examples (#2252) * fix: elements position in HTMLOverlay when visibility is changed from hide to show (#2251) * Fixed elements position, after unhiding the elements from hidden state Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v16.11.42 (#2253) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: incorrect node transform override on certain boundary conditions (#2256) * refactor: convert transform override texture to floating point data texture * refactor: convert transform override index pointer texture to floating point data texture * fix: reallocating override texture adding wrong available matrix indices * chore: add visual test snap * fix: change obsolete threejs getInverse to repair example * chore: remove unused float packing shader utility * refactor: remove magic number Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: sector repository gracefully handle sectors loader errors (#2257) * chore(deps): update dependency nock to v13.2.8 (#2258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>

* chore: bump reveal version 3.x doc (#2231) * chore: bump reveal version 3.x doc * Updated 3.x docs Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2162) * fix(deps): update dependency three to v0.141.0 * fix: undo documentation three bump * chore: bump three for examples Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com> * refactor: port core package to api package (#2192) * chore: move file type mocks to test utilities * refactor: remove unused types * refactor: move all internal export to root * refactor: port core to new api package * fix: restore build * fix: ignore typing error from geomap * fix: restore tests Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * improvement: avoid stalling rendering by adding asynchronous picking (#2191) * fix: backport threejs for documentation to fix v1 doc (#2237) * chore(deps): update dependency gl to v5.0.3 (#2238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * test: added test for Cognite3dViewer.dispose() (#2141) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * improvement: hide/show HTML overlay elements (#2240) * Added API to show/hide HTMLOverlay elements Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v13.0.3 (#2241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: mobile default settings should not include ssao, add iPad fix (#2239) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: in-front objects incorrectly blending with background (#2248) * fix: in-front objects now incorrectly blending * chore: update visual tests * chore: bump to Webpack 5 (#2244) * feat: migrate examples to webpack-5 * improvement: simplify and de-deprecate config-overrides * feat: upgrade to webpack 5 in viewer * fix: correct watchOptions.ignored field * fix: visual tests in examples * feat: update webpack config for example apps * chore: add temporary entrypoint+dependency in webpack conf * fix: make examples correctly pick up three js * fix: replace react-rewired stuff with own wepback config * improvement: add log of which visual test is running * fix: use better OpenGL backend in puppeteer * test: update visual test images * fix: fix test images after updating GPU backend * improvement: simplify viewer webpack config * chore: lint fix * fix: add environment variable for production build * feat: also serve content from examples/public * fix: try backporting pupeteer webgl backend for fixing CI tests * chore: attempt to build reveal in prod for documentation * chore: remove unused variable and update label * chore: update documentation yarn.lock * fix: restore tests from wrong merge * fix: update visual tests after merge... again... Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com> * chore(deps): update dependency ts-loader to v9.3.1 (#2249) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency core-js to v3.23.3 (#2243) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: improper linking of viewer into examples (#2252) * fix: elements position in HTMLOverlay when visibility is changed from hide to show (#2251) * Fixed elements position, after unhiding the elements from hidden state Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v16.11.42 (#2253) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: incorrect node transform override on certain boundary conditions (#2256) * refactor: convert transform override texture to floating point data texture * refactor: convert transform override index pointer texture to floating point data texture * fix: reallocating override texture adding wrong available matrix indices * chore: add visual test snap * fix: change obsolete threejs getInverse to repair example * chore: remove unused float packing shader utility * refactor: remove magic number Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: sector repository gracefully handle sectors loader errors (#2257) * chore(deps): update dependency nock to v13.2.8 (#2258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: manually loop unroll in shader to improve performance (#2265) * improvement: better error message when adding model fails (#2266) * chore(deps): update dependency jest to v28 (#2088) * chore(deps): update dependency jest to v28 * chore: fix broken github actions for preview docs comment on Github (#2276) * chore: fix broken github actions for preview docs comment on Github * Use GitHub CLI * Replace action task with Github CLI * Checkout to provide con * Use correct Ruby * Go for something that works * Use of forked comment-on-pr * Use our own fork with release tag * lint Co-authored-by: Savelii Novikov <kvaka2000@gmail.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com> Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>

* feat: rectify point cloud object styling API * feat: add visibility as appearance option * fix: some errors lying around * chore: lint fix * test: correct change to new API * feat: update API to expose annotation IDs * improvement: rename annotation object collection * improvement: give proper typing to Ept Json input * feat: only expose annotationId and optional assetId publicly * chore: lint fix * feat: flesh out PointCloudObjectCollection interface a bit * improvement: change point cloud object interface to base class * chore: undo changes to yarn.lock * doc: add some tsdoc to exposed classes * chore: lint fix * docs: add 4.0 documentation for point cloud styling API * test: add visual test for point cloud styling * refactor: rename and update various parts of point cloud code * docs: Add point cloud README * improvement: make PointCloudAppearance require all fields * test: add shapes tests * chore: lint fix * test: add another unit test * test: fix latest unit test * chore: lint fix * test: add to the visual test to make it more meaningful Otherwise it didn't really test anything... * improvement: simplify cylinder construction * fix: make sure all annotations are fetched, not just the 25 first * revert: revert unnecessary changes to package.json * fix: broken PointCloudFactory test * fix: example * test: update visual test image * improvement: rename point cloud styling visual test * refactor: remove CogniteClientPlayground dependency * Update viewer/packages/pointclouds/src/PointCloudFactory.ts Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> * test: add another PointCloudFactory test * improvement: remove unused function * improvement: simplify access to default styling * improvement: rename function (set -> assign) * chore: lint fix * refactor: factor out and simplify PointCloudObjectProvider * improvement: remove intermediate geometry translation step * test: add ObjectAppearanceTexture test * test: add another ObjectAppearanceTexture test * improvement: ObjectAppearanceTexture -> PointCloudAppearanceTexture * refactor: rename object collection classes * improvement: rename fillPartialPointCloudAppearance * improvement: give better name to variables * fix: correct number of arguments to constructors * chore: lint fix * improvement: mock cognite client in visual tests * improvement: mock CogniteClient in visual tests * fix: correct name of point cloud object collection * fix: restrict version of sdk peer dependency * improvement: make new non-optional style argument type * rename: PointCloudObjectAppearance -> PointCloudAppearance Since it doesn't always apply to objects, could be a default style * docs: Add more TSDoc on public-facing constructs * chore: lint fix * fix: redraw on default point cloud style update * fix: update to compatible SDK version in documentation * docs: properly add point cloud styling to side bar * fix: correct documentation sidebar link * Update documentation/docs/examples/pointcloud-styling.mdx * Reorder * Adjust doc * Update examples/src/utils/PointCloudObjectStylingUI.ts Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> * Update viewer/packages/pointclouds/src/styling/AnnotationListPointCloudObjectCollection.ts Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> * fix: remove unnecessary client argument * refactor: separate Cdf and local point cloud factories * improvement: remove unused assignment * fix: remove unused import Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com>

* fix: allow libraries in workers NB: Splits the webpack config to avoid bundling ThreeJS in more than one output. Further investigation required to figure out how to not bundle ThreeJS at all * chore: clean up * chore: lint fix

…oing picking (#2235) Added support for conversion between objectId and annotationId for point cloud objects. Also point cloud picking now returns annotationId of the object that corresponds to clicked point.

* feat: add workerize as a worker loader * fix: transfer large array instead of copy when sending/getting data from workers * feat: consume workerize-transferable to add transferable capability to workerize-loader * chore: remove copywrite headers for adopted code, remove dead code * fix: remove self-assignment * fix: add webworker lib for typedoc generation Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

#2359) * Merge branch 'master' into hflatval/update-point-cloud-feature-branch3 * fix: also remove CAD preview from v. 4

* feat: Webassembly setup

…assignment (#2327) Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>

chore: update feature branch from master cleanup: Remove API reference from version-4.x fix: remove merge conflict marker cleanup: remove unused files chore: don't expose 4.x publicly yet fix: restore API reference file for v2 chore: lint fix chore: remove V8-related things from visual tests fix: SphereBufferGeometry => SphereGeometry chore: cleanup unused argument in point cloud styling docs chore: update yarn lock chore: revert some mismerged paths improvement: import THREE from reveal in PointCloud styling UI chore: update docs/api

…ntcloud-master-merge

Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>

…se object bounding boxes (#2522)

* fix: point cloud bounding box shenanigans * test: add test for point cloud transformation * fix: height visualization for point clouds * chore: add type to test utility function * Update viewer/test-utilities/src/createPointCloudModel.ts Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> * chore: reduce number of characters in code Not in commit message * chore: lint fix Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com>

* fix: avoid GUI folder name collision in Viewer Crash occured if more than one point cloud model was added * fix: remove unnecessary child-parent assignment * fix: typo in ModelUi * chore: update yarn lock

* fix: export point cloud object metadata * fix: typo in docs

* refactor: factor out pointcloud-styling package

viewer/packages/pointclouds/src/PotreeGroupWrapper.ts

lgtm-com · 2022-10-17T14:04:52Z

This pull request introduces 2 alerts when merging 77b7c5d into 9ff34b2 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

github-actions · 2022-10-17T14:22:39Z

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

github-actions · 2022-10-17T14:26:27Z

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

github-actions · 2022-10-17T15:02:04Z

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

github-actions · 2022-10-17T15:04:23Z

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

haakonflatval-cognite and others added 30 commits June 14, 2022 11:13

fix: matrix rotation math (#2177)

b893b29

fix: cylinder handling (#2178)

31286a0

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

Latest master

c18b3be

lint

64d7c46

fix: matrix rotation math (#2177)

3308c6e

fix: cylinder handling (#2178)

4609e1d

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

Merge branch 'feat/point-cloud-styling' of https://github.com/cognite…

d24e24f

…data/reveal into feat/point-cloud-styling

chore: Fix triple import error and sdk-playground version from latest…

abb6642

… master rebase (#2233) Fixed errors after rebase

feat: libraries in workers (#2269)

5018205

* fix: allow libraries in workers NB: Splits the webpack config to avoid bundling ThreeJS in more than one output. Further investigation required to figure out how to not bundle ThreeJS at all * chore: clean up * chore: lint fix

improvement: Return annotationId of clicked point cloud object when d…

af815bc

…oing picking (#2235) Added support for conversion between objectId and annotationId for point cloud objects. Also point cloud picking now returns annotationId of the object that corresponds to clicked point.

Merge branch 'master' into hflatval/update-point-cloud-feature-branch3 (

a400e08

#2359) * Merge branch 'master' into hflatval/update-point-cloud-feature-branch3 * fix: also remove CAD preview from v. 4

feat: Webassembly setup (#2353)

8795a53

* feat: Webassembly setup

Update point cloud feature branch from master (#2416)

0e754a9

feat: Rust/Webassembly octree implementation for faster point-object …

269dea0

…assignment (#2327) Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>

Merge commit '22fd033caa5317c6fe92f57bcc529928d2465e41' into temp/poi…

1c84ab5

…ntcloud-master-merge

feat: custom classification (#2320)

3ae0e11

Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>

docs: finalize point cloud styling docs (#2500)

ca1fcc1

refactor: move point cloud object provider to data-providers and expo…

97de3e6

…se object bounding boxes (#2522)

improvement: various fixes for point clouds (#2551)

d903b99

* fix: avoid GUI folder name collision in Viewer Crash occured if more than one point cloud model was added * fix: remove unnecessary child-parent assignment * fix: typo in ModelUi * chore: update yarn lock

Merge branch 'master' into hflatval/update-point-cloud-feature-branch6

b22e987

fix: export point cloud object metadata (#2552)

a923c5f

* fix: export point cloud object metadata * fix: typo in docs

refactor: point cloud styling package (#2560)

4f349e2

* refactor: factor out pointcloud-styling package

improvement: rename inner getter

0d834ad

haakonflatval-cognite commented Oct 17, 2022

View reviewed changes

viewer/packages/pointclouds/src/PotreeGroupWrapper.ts Show resolved Hide resolved

haakonflatval-cognite added 6 commits October 17, 2022 15:19

improvement: remove unused type definition

ae9e469

fix: remove package dependencies from yarn.lock too

12552f9

improvement: remove yet another unused type definition

2372fc0

improvement: rename classification type

69b74c0

fix: remove outdated wasm folder from gitignore

77b7c5d

fix: revert bad removal in package.json

6b17354

haakonflatval-cognite added 5 commits October 17, 2022 16:06

refactor: use map's built-in index counter

421c510

improvement: split doc sentences to separate lines

5619fa0

improvement: invert if

7a38233

fix: clarify promise awaiting with Promise.all

a912da2

chore: lint fix

5df85f2

haakonflatval-cognite added 3 commits October 17, 2022 16:39

improvement: contract return statement

3aea2f0

improvement: factor out types for point cloud worker

b9f36b8

chore: lint fix

7386117

haakonflatval-cognite added 2 commits October 18, 2022 10:25

fix: correct object ID assignment in annotation transformation

4fab476

fix: put back a couple more characters in viewer/package.json

91c9730

christjt approved these changes Oct 18, 2022

View reviewed changes

haakonflatval-cognite and others added 5 commits October 18, 2022 11:14

refactor: rename SchemaEntry

8a02b97

improvement: reduce worker pool size

e8aa2aa

cleanup: remove legacy compile script

ebbb217

fix: lower-case lib field in tsconfig

00abb8a

Merge branch 'master' into feat/point-cloud-styling

13864dc

haakonflatval-cognite merged commit 50ba964 into master Oct 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: point cloud styling #2569

feat: point cloud styling #2569

haakonflatval-cognite commented Oct 14, 2022 •

edited by larsmoa

Loading

lgtm-com bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

feat: point cloud styling #2569

feat: point cloud styling #2569

Conversation

haakonflatval-cognite commented Oct 14, 2022 • edited by larsmoa Loading

Description

Main features:

Models for testing

Checklist:

lgtm-com bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

github-actions bot commented Oct 17, 2022

haakonflatval-cognite commented Oct 14, 2022 •

edited by larsmoa

Loading