improvement: better error message when adding model fails #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsmoa
added
auto-update
larsmoa
added
slack
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
+ Coverage 71.56% 71.58% +0.01%
==========================================
Files 254 254
Lines 10852 10852
Branches 1415 1415
==========================================
+ Hits 7766 7768 +2
+ Misses 2927 2925 -2
Partials 159 159
|
|
📙 Documentation preview is available from |
christjt
approved these changes
Jul 4, 2022
haakonflatval-cognite
added a commit
that referenced
this pull request
Jul 15, 2022
* chore: bump reveal version 3.x doc (#2231) * chore: bump reveal version 3.x doc * Updated 3.x docs Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2162) * fix(deps): update dependency three to v0.141.0 * fix: undo documentation three bump * chore: bump three for examples Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com> * refactor: port core package to api package (#2192) * chore: move file type mocks to test utilities * refactor: remove unused types * refactor: move all internal export to root * refactor: port core to new api package * fix: restore build * fix: ignore typing error from geomap * fix: restore tests Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix(deps): update dependency three to v0.141.0 (#2234) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * improvement: avoid stalling rendering by adding asynchronous picking (#2191) * fix: backport threejs for documentation to fix v1 doc (#2237) * chore(deps): update dependency gl to v5.0.3 (#2238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * test: added test for Cognite3dViewer.dispose() (#2141) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * improvement: hide/show HTML overlay elements (#2240) * Added API to show/hide HTMLOverlay elements Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v13.0.3 (#2241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: mobile default settings should not include ssao, add iPad fix (#2239) Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: in-front objects incorrectly blending with background (#2248) * fix: in-front objects now incorrectly blending * chore: update visual tests * chore: bump to Webpack 5 (#2244) * feat: migrate examples to webpack-5 * improvement: simplify and de-deprecate config-overrides * feat: upgrade to webpack 5 in viewer * fix: correct watchOptions.ignored field * fix: visual tests in examples * feat: update webpack config for example apps * chore: add temporary entrypoint+dependency in webpack conf * fix: make examples correctly pick up three js * fix: replace react-rewired stuff with own wepback config * improvement: add log of which visual test is running * fix: use better OpenGL backend in puppeteer * test: update visual test images * fix: fix test images after updating GPU backend * improvement: simplify viewer webpack config * chore: lint fix * fix: add environment variable for production build * feat: also serve content from examples/public * fix: try backporting pupeteer webgl backend for fixing CI tests * chore: attempt to build reveal in prod for documentation * chore: remove unused variable and update label * chore: update documentation yarn.lock * fix: restore tests from wrong merge * fix: update visual tests after merge... again... Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com> * chore(deps): update dependency ts-loader to v9.3.1 (#2249) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency core-js to v3.23.3 (#2243) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: improper linking of viewer into examples (#2252) * fix: elements position in HTMLOverlay when visibility is changed from hide to show (#2251) * Fixed elements position, after unhiding the elements from hidden state Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v16.11.42 (#2253) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: incorrect node transform override on certain boundary conditions (#2256) * refactor: convert transform override texture to floating point data texture * refactor: convert transform override index pointer texture to floating point data texture * fix: reallocating override texture adding wrong available matrix indices * chore: add visual test snap * fix: change obsolete threejs getInverse to repair example * chore: remove unused float packing shader utility * refactor: remove magic number Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: sector repository gracefully handle sectors loader errors (#2257) * chore(deps): update dependency nock to v13.2.8 (#2258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> * fix: manually loop unroll in shader to improve performance (#2265) * improvement: better error message when adding model fails (#2266) * chore(deps): update dependency jest to v28 (#2088) * chore(deps): update dependency jest to v28 * chore: fix broken github actions for preview docs comment on Github (#2276) * chore: fix broken github actions for preview docs comment on Github * Use GitHub CLI * Replace action task with Github CLI * Checkout to provide con * Use correct Ruby * Go for something that works * Use of forked comment-on-pr * Use our own fork with release tag * lint Co-authored-by: Savelii Novikov <kvaka2000@gmail.com> Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com> Co-authored-by: Savokr <savelii.novikov@cognite.com> Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com> Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com> Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping standard template due to the nature of (i.e. tiny) PR.