improvement: avoid stalling rendering by adding asynchronous picking

[larsmoa]

Description

Avoid blocking main thread when doing intersection tests to reduce "staggering" when doing picking. Also fixed a typo in PR template.

Checklist:

Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.

• I am proud of this feature.
• I have performed a self-review of my own code.
• I have manually tested this for different scenarios (different models, formats, devices, browsers).
• I have commented my code in hard-to-understand areas.
• I have made corresponding changes to the public documentation.
• I have added unit and visuals tests to prove that my feature works to the best of my ability.
  Unit test not added. Spent some time trying, but could not create a sensible test that actually tested anything substantial.
• I have refactored the code for readability to the best of my ability.
• I have checked that my changes do not introduce regressions in the public documentation.
• I have outlined any known defects / lacking capabilities in the contents of this PR.
• I have listed any remaining work that should follow this PR.
• I have added TSDoc to any public facing changes.
• I have added "developer documentation" in any package README.md that is related / applicable to this PR.
• I have noted down and am currently tracking any technical debt introduced in this PR.
• I have thoroughly thought about the architecture of this implementation.
• I have asked peers to test this feature when I have been in doubt.
  Tested Chrome, Safari, Chrome Canary, iOS Safari.

[github-actions]

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

[github-actions]

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

[github-actions]

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

[codecov]

Codecov Report

Merging #2191 (8b6dd39) into master (747aa2a) will decrease coverage by 0.28%.
The diff coverage is 21.87%.

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
- Coverage   71.01%   70.73%   -0.29%     
==========================================
  Files         254      255       +1     
  Lines       10826    10879      +53     
  Branches     1407     1415       +8     
==========================================
+ Hits         7688     7695       +7     
- Misses       2979     3021      +42     
- Partials      159      163       +4     

Impacted Files	Coverage Δ
...ckages/api/src/public/migration/Cognite3DViewer.ts	59.27% <0.00%> (ø)
...cad-model/src/picking/readPixelsFromTargetAsync.ts	9.80% <9.80%> (ø)
...r/packages/cad-model/src/picking/PickingHandler.ts	65.82% <75.00%> (+0.88%)	⬆️

[github-actions]

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/2191/docs/next/.

[larsmoa]

Looks good, but can't say I see much change in performance on this branch vs. master. Do you have a tip for a good test scenario to make the difference shine through more?

Not really. It won't feel very different in most cases as it only helps when GPU has a lot of work to do. This helps in those situations by yielding control back to main thread so e.g. UI can be updated before picking results are ready.

[haakonflatval-cognite]

LGTM 👍