Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port core package to api package #2192

Merged
merged 36 commits into from
Jun 21, 2022
Merged

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Jun 9, 2022

Will defer merging this until 3.1.0 is released, due to a relative large chance that this brakes something.

Still things that can be structured better, the contents of the API package havne't really changed that much from what core was. But this is a first step.

NOTE: ended up updating the 'jest-extended' lib in this PR which is not ideal. But when I ported the old version broke and it was very hard to find the correct setup for the old version.

@christjt christjt requested a review from a team as a code owner June 9, 2022 08:53
@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Jun 9, 2022
@christjt christjt added the do-not-merge Don't merge this PR yet. label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2192 (7cce2c4) into master (6b463af) will increase coverage by 0.01%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
+ Coverage   70.98%   70.99%   +0.01%     
==========================================
  Files         259      254       -5     
  Lines       10856    10826      -30     
  Branches     1407     1407              
==========================================
- Hits         7706     7686      -20     
+ Misses       2991     2981      -10     
  Partials      159      159              
Impacted Files Coverage Δ
viewer/.eslintrc.js 0.00% <ø> (ø)
viewer/index.ts 0.00% <0.00%> (ø)
viewer/internals.ts 0.00% <0.00%> (ø)
viewer/jest.config.js 0.00% <ø> (ø)
viewer/packages/api/src/migration.ts 0.00% <ø> (ø)
viewer/packages/api/src/public/RevealManager.ts 69.02% <ø> (ø)
...wer/packages/api/src/public/createRevealManager.ts 87.87% <ø> (ø)
...ckages/api/src/public/migration/Cognite3DViewer.ts 59.27% <0.00%> (ø)
...kages/api/src/public/migration/RenderController.ts 100.00% <ø> (ø)
...s/api/src/public/migration/renderOptionsHelpers.ts 45.97% <ø> (ø)
... and 23 more

@christjt christjt removed the do-not-merge Don't merge this PR yet. label Jun 21, 2022
@christjt christjt merged commit 747aa2a into master Jun 21, 2022
@christjt christjt deleted the christjt/refactor-core branch June 21, 2022 16:56
haakonflatval-cognite added a commit that referenced this pull request Jul 4, 2022
* chore: bump reveal version 3.x doc (#2231)

* chore: bump reveal version 3.x doc

* Updated 3.x docs

Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency three to v0.141.0 (#2162)

* fix(deps): update dependency three to v0.141.0

* fix: undo documentation three bump

* chore: bump three for examples

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com>

* refactor: port core package to api package (#2192)

* chore: move file type mocks to test utilities

* refactor: remove unused types

* refactor: move all internal export to root

* refactor: port core to new api package

* fix: restore build

* fix: ignore typing error from geomap

* fix: restore tests

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix(deps): update dependency three to v0.141.0 (#2234)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* improvement: avoid stalling rendering by adding asynchronous picking (#2191)

* fix: backport threejs for documentation to fix v1 doc (#2237)

* chore(deps): update dependency gl to v5.0.3 (#2238)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* test: added test for Cognite3dViewer.dispose() (#2141)

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* improvement: hide/show HTML overlay elements (#2240)

* Added API to show/hide HTMLOverlay elements

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency lint-staged to v13.0.3 (#2241)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: mobile default settings should not include ssao, add iPad fix (#2239)

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: in-front objects incorrectly blending with background (#2248)

* fix: in-front objects now incorrectly blending

* chore: update visual tests

* chore: bump to Webpack 5 (#2244)

* feat: migrate examples to webpack-5

* improvement: simplify and de-deprecate config-overrides

* feat: upgrade to webpack 5 in viewer

* fix: correct watchOptions.ignored field

* fix: visual tests in examples

* feat: update webpack config for example apps

* chore: add temporary entrypoint+dependency in webpack conf

* fix: make examples correctly pick up three js

* fix: replace react-rewired stuff with own wepback config

* improvement: add log of which visual test is running

* fix: use better OpenGL backend in puppeteer

* test: update visual test images

* fix: fix test images after updating GPU backend

* improvement: simplify viewer webpack config

* chore: lint fix

* fix: add environment variable for production build

* feat: also serve content from examples/public

* fix: try backporting pupeteer webgl backend for fixing CI tests

* chore: attempt to build reveal in prod for documentation

* chore: remove unused variable and update label

* chore: update documentation yarn.lock

* fix: restore tests from wrong merge

* fix: update visual tests after merge... again...

Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com>

* chore(deps): update dependency ts-loader to v9.3.1 (#2249)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency core-js to v3.23.3 (#2243)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: improper linking of viewer into examples (#2252)

* fix: elements position in HTMLOverlay when visibility is changed from hide to show (#2251)

* Fixed elements position, after unhiding the elements from hidden state

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to v16.11.42 (#2253)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: incorrect node transform override on certain boundary conditions (#2256)

* refactor: convert transform override texture to floating point data texture

* refactor: convert transform override index pointer texture to floating point data texture

* fix: reallocating override texture adding wrong available matrix indices

* chore: add visual test snap

* fix: change obsolete threejs getInverse to repair example

* chore: remove unused float packing shader utility

* refactor: remove magic number

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: sector repository gracefully handle sectors loader errors (#2257)

* chore(deps): update dependency nock to v13.2.8 (#2258)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com>
Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com>
Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>
haakonflatval-cognite added a commit that referenced this pull request Jul 15, 2022
* chore: bump reveal version 3.x doc (#2231)

* chore: bump reveal version 3.x doc

* Updated 3.x docs

Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency three to v0.141.0 (#2162)

* fix(deps): update dependency three to v0.141.0

* fix: undo documentation three bump

* chore: bump three for examples

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com>

* refactor: port core package to api package (#2192)

* chore: move file type mocks to test utilities

* refactor: remove unused types

* refactor: move all internal export to root

* refactor: port core to new api package

* fix: restore build

* fix: ignore typing error from geomap

* fix: restore tests

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix(deps): update dependency three to v0.141.0 (#2234)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* improvement: avoid stalling rendering by adding asynchronous picking (#2191)

* fix: backport threejs for documentation to fix v1 doc (#2237)

* chore(deps): update dependency gl to v5.0.3 (#2238)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* test: added test for Cognite3dViewer.dispose() (#2141)

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* improvement: hide/show HTML overlay elements (#2240)

* Added API to show/hide HTMLOverlay elements

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency lint-staged to v13.0.3 (#2241)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: mobile default settings should not include ssao, add iPad fix (#2239)

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: in-front objects incorrectly blending with background (#2248)

* fix: in-front objects now incorrectly blending

* chore: update visual tests

* chore: bump to Webpack 5 (#2244)

* feat: migrate examples to webpack-5

* improvement: simplify and de-deprecate config-overrides

* feat: upgrade to webpack 5 in viewer

* fix: correct watchOptions.ignored field

* fix: visual tests in examples

* feat: update webpack config for example apps

* chore: add temporary entrypoint+dependency in webpack conf

* fix: make examples correctly pick up three js

* fix: replace react-rewired stuff with own wepback config

* improvement: add log of which visual test is running

* fix: use better OpenGL backend in puppeteer

* test: update visual test images

* fix: fix test images after updating GPU backend

* improvement: simplify viewer webpack config

* chore: lint fix

* fix: add environment variable for production build

* feat: also serve content from examples/public

* fix: try backporting pupeteer webgl backend for fixing CI tests

* chore: attempt to build reveal in prod for documentation

* chore: remove unused variable and update label

* chore: update documentation yarn.lock

* fix: restore tests from wrong merge

* fix: update visual tests after merge... again...

Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com>

* chore(deps): update dependency ts-loader to v9.3.1 (#2249)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency core-js to v3.23.3 (#2243)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: improper linking of viewer into examples (#2252)

* fix: elements position in HTMLOverlay when visibility is changed from hide to show (#2251)

* Fixed elements position, after unhiding the elements from hidden state

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to v16.11.42 (#2253)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: incorrect node transform override on certain boundary conditions (#2256)

* refactor: convert transform override texture to floating point data texture

* refactor: convert transform override index pointer texture to floating point data texture

* fix: reallocating override texture adding wrong available matrix indices

* chore: add visual test snap

* fix: change obsolete threejs getInverse to repair example

* chore: remove unused float packing shader utility

* refactor: remove magic number

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: sector repository gracefully handle sectors loader errors (#2257)

* chore(deps): update dependency nock to v13.2.8 (#2258)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>

* fix: manually loop unroll in shader to improve performance (#2265)

* improvement: better error message when adding model fails (#2266)

* chore(deps): update dependency jest to v28 (#2088)

* chore(deps): update dependency jest to v28

* chore: fix broken github actions for preview docs comment on Github (#2276)

* chore: fix broken github actions for preview docs comment on Github

* Use GitHub CLI

* Replace action task with Github CLI

* Checkout to provide con

* Use correct Ruby

* Go for something that works

* Use of forked comment-on-pr

* Use our own fork with release tag

* lint

Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>

Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com>
Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com>
Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>
Co-authored-by: Savelii Novikov <kvaka2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants