Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update point cloud feature branch #2416

Merged
merged 155 commits into from
Sep 9, 2022
Merged

Update point cloud feature branch #2416

merged 155 commits into from
Sep 9, 2022

Conversation

haakonflatval-cognite
Copy link
Contributor

Description

Regular update w/ merge from master to feature branch

Checklist:

Here is a checklist that should completed before merging this given feature.
Any shortcomings from the items below should be explained and detailed within the contents of this PR.

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

christjt and others added 30 commits June 21, 2022 13:51
@christjt @Savokr @cognite-bulldozer
chore: bump reveal version 3.x doc (#2231)
efdea15 
* chore: bump reveal version 3.x doc

* Updated 3.x docs

Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency @cognite/sdk to v7.6.2 (#2220)
e87f494 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @cognite/sdk to v7.7.0 (#2232)
bcf45e0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christjt
fix(deps): update dependency three to v0.141.0 (#2162)
6b463af 
* fix(deps): update dependency three to v0.141.0

* fix: undo documentation three bump

* chore: bump three for examples

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christopher Tannum <christopher.tannum@cognite.com>
@christjt @cognite-bulldozer
refactor: port core package to api package (#2192)
747aa2a 
* chore: move file type mocks to test utilities

* refactor: remove unused types

* refactor: move all internal export to root

* refactor: port core to new api package

* fix: restore build

* fix: ignore typing error from geomap

* fix: restore tests

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency three to v0.141.0 (#2234)
a110f6f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@larsmoa
improvement: avoid stalling rendering by adding asynchronous picking (#…
a4d35b8 
…2191)
@christjt
fix: backport threejs for documentation to fix v1 doc (#2237)
796326b
@renovate @cognite-bulldozer
chore(deps): update dependency gl to v5.0.3 (#2238)
c1a7fba 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@larsmoa @cognite-bulldozer
test: added test for Cognite3dViewer.dispose() (#2141)
d21a317 
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@pramodcog @cognite-bulldozer
improvement: hide/show HTML overlay elements (#2240)
2caf33f 
* Added API to show/hide HTMLOverlay elements

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency lint-staged to v13.0.3 (#2241)
7d858f3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@christjt @cognite-bulldozer
fix: mobile default settings should not include ssao, add iPad fix (#…
13acf73 
…2239)

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@christjt
fix: in-front objects incorrectly blending with background (#2248)
eac1567 
* fix: in-front objects now incorrectly blending

* chore: update visual tests
@christjt @haakonflatval-cognite
chore: bump to Webpack 5 (#2244)
95d1d8a 
* feat: migrate examples to webpack-5

* improvement: simplify and de-deprecate config-overrides

* feat: upgrade to webpack 5 in viewer

* fix: correct watchOptions.ignored field

* fix: visual tests in examples

* feat: update webpack config for example apps

* chore: add temporary entrypoint+dependency in webpack conf

* fix: make examples correctly pick up three js

* fix: replace react-rewired stuff with own wepback config

* improvement: add log of which visual test is running

* fix: use better OpenGL backend in puppeteer

* test: update visual test images

* fix: fix test images after updating GPU backend

* improvement: simplify viewer webpack config

* chore: lint fix

* fix: add environment variable for production build

* feat: also serve content from examples/public

* fix: try backporting pupeteer webgl backend for fixing CI tests

* chore: attempt to build reveal in prod for documentation

* chore: remove unused variable and update label

* chore: update documentation yarn.lock

* fix: restore tests from wrong merge

* fix: update visual tests after merge... again...

Co-authored-by: Håkon Flatval <hakon.flatval@cognite.com>
@renovate
chore(deps): update dependency ts-loader to v9.3.1 (#2249)
ac009f9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency typedoc-plugin-markdown to v3.13.1 (#2247
f7958aa 
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency core-js to v3.23.3 (#2243)
f62ca17 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update typescript-eslint monorepo to v5.30.0 (#2246)
2383036 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency eslint-plugin-prettier to v4.1.0 (#2245)
ef238a8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@christjt
fix: improper linking of viewer into examples (#2252)
96f4e19
@pramodcog @cognite-bulldozer
fix: elements position in HTMLOverlay when visibility is changed from…
5bfdf62 
… hide to show (#2251)

* Fixed elements position, after unhiding the elements from hidden state

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency @types/node to v16.11.42 (#2253)
888e0ee 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency eslint-plugin-prettier to v4.2.1 (#2255)
8aa6f49 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency webpack-dev-server to v4.9.3 (#2254)
077df3c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@christjt @cognite-bulldozer
fix: incorrect node transform override on certain boundary conditions (…
fe85758 
…#2256)

* refactor: convert transform override texture to floating point data texture

* refactor: convert transform override index pointer texture to floating point data texture

* fix: reallocating override texture adding wrong available matrix indices

* chore: add visual test snap

* fix: change obsolete threejs getInverse to repair example

* chore: remove unused float packing shader utility

* refactor: remove magic number

Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@christjt
fix: sector repository gracefully handle sectors loader errors (#2257)
3f41888
@renovate @cognite-bulldozer
chore(deps): update dependency nock to v13.2.8 (#2258)
14047ae 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@renovate @cognite-bulldozer
chore(deps): update dependency typedoc-plugin-markdown to v3.13.2 (#2259
7272757 
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: cognite-bulldozer[bot] <51074376+cognite-bulldozer[bot]@users.noreply.github.com>
@christjt
fix: manually loop unroll in shader to improve performance (#2265)
b40955a
@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Sep 9, 2022
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 9, 2022 08:01
@haakonflatval-cognite haakonflatval-cognite changed the title Hflatval/update point cloud feature branch4 Hflatval/update point cloud feature branch Sep 9, 2022
@haakonflatval-cognite haakonflatval-cognite changed the title Hflatval/update point cloud feature branch Update point cloud feature branch Sep 9, 2022
Savokr
Savokr approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging f10f5bc into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #2416 (284cfdf) into feat/point-cloud-styling (d765a15) will decrease coverage by 1.33%.
The diff coverage is 60.00%.

@@                     Coverage Diff                      @@
##           feat/point-cloud-styling    #2416      +/-   ##
============================================================
- Coverage                     70.37%   69.03%   -1.34%     
============================================================
  Files                           271      261      -10     
  Lines                         11072    11311     +239     
  Branches                       1405     1458      +53     
============================================================
+ Hits                           7792     7809      +17     
- Misses                         3123     3328     +205     
- Partials                        157      174      +17
Impacted Files Coverage Δ
viewer/.eslintrc.js 0.00% <ø> (ø)
viewer/index.ts 0.00% <0.00%> (ø)
viewer/jest.config.js 0.00% <ø> (ø)
viewer/packages/api/src/migration.ts 0.00% <ø> (ø)
viewer/packages/api/src/public/types.ts 100.00% <ø> (ø)
viewer/packages/api/src/utilities/Spinner.ts 84.37% <ø> (ø)
...er/packages/cad-geometry-loaders/src/CadManager.ts 57.00% <ø> (ø)
.../cad-geometry-loaders/src/CadModelUpdateHandler.ts 72.09% <ø> (+5.81%) ⬆️
...es/cad-geometry-loaders/src/sector/SectorLoader.ts 91.95% <ø> (ø)
...s/cad-geometry-loaders/src/sector/culling/types.ts 100.00% <ø> (ø)
... and 140 more

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging eaa1b51 into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging 343338c into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging d7606a1 into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging 89f23dc into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging ce58d3a into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) September 9, 2022 11:33
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 1 alert when merging 284cfdf into 8795a53 - view on LGTM.com

fixed alerts:

  • 1 for Unvalidated dynamic method call

@haakonflatval-cognite haakonflatval-cognite merged commit 0e754a9 into feat/point-cloud-styling Sep 9, 2022
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/update-point-cloud-feature-branch4 branch September 9, 2022 11:42
haakonflatval-cognite added a commit that referenced this pull request Oct 18, 2022
@haakonflatval-cognite @larsmoa
@christjt @Savokr @pramodcog
feat: point cloud styling (#2569)
50ba964 
* feat: Add ability to style objects in point clouds (#2104)

* feat: point cloud API for styling (#2179)

* feat: Webassembly setup (#2353)

* Update point cloud feature branch from master (#2416)

* feat: Rust/Webassembly octree implementation for faster point-object assignment (#2327)

* feat: custom classification (#2320)

* docs: finalize point cloud styling docs (#2500)

* refactor: move point cloud object provider to data-providers and expose object bounding boxes (#2522)

* fix: point cloud custom transformation (#2550)

* improvement: various fixes for point clouds (#2551)

* fix: export point cloud object metadata (#2552)

* Various big and small fixes

Co-authored-by: Lars Moastuen <lars.moastuen@cognite.com>
Co-authored-by: Christopher J. Tannum <christopher.tannum@cognite.com>
Co-authored-by: Savokr <savelii.novikov@cognite.com>
Co-authored-by: Pramod S <87521752+pramodcog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Savokr Savokr Savokr approved these changes

Assignees
No one assigned
Labels
slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haakonflatval-cognite @Savokr @christjt @larsmoa @pramodcog @Strepto