(hotfix) fix conversion price #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazz-cb
approved these changes
Aug 16, 2024
Merged
alex-stone
added a commit
that referenced
this pull request
Aug 22, 2024
### What changed? Why? ## [0.1.0] - 2024-08-22 - Add support for listing historical balances for a wallet, defaulting to the historical_balances function for wallet: listing historical balances for default address of the wallet. - Expose all networks as constants, e.g. `Coinbase::Network::ETHEREUM_MAINNET` - Add support for managing Webhooks. - Add support for listing smart contract events. - Add support for Dedicated ETH Staking for wallet addresses ### Breaking Changes - All method signatures that took a `network_id` now take a `network` that can be either a network constant (e.g. `Coinbase::Network::BASE_MAINNET`) or a network ID (e.g. `:base_mainnet`) ### Added - Add to_address_id method to Transaction class - Remove "pending" status from staking operation status #148 #140 #154 #149 #156 #136 #150 #153 #138 #158 #155 #161 #157 #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... --> --------- Co-authored-by: Chaoya Ji <chaoya.ji@coinbase.com> Co-authored-by: xinyu-li-cb <142266583+xinyu-li-cb@users.noreply.github.com> Co-authored-by: Rohit Durvasula <rohit.durvasula@coinbase.com> Co-authored-by: Rohit Durvasula <88731568+drohit-cb@users.noreply.github.com> Co-authored-by: CJ_Andy <109100734+chaoyaji-cb@users.noreply.github.com> Co-authored-by: Shreif Abdallah <shreif.abdallah@coinbase.com> Co-authored-by: shreifabdallah <129977880+shreifabdallah@users.noreply.github.com> Co-authored-by: jinghanx <jinghanx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
100Testing notes
make replResults show correct conversion price for ETH
Qualified Impact