Release: V0.1.0 #159
Merged
Release: V0.1.0 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changed? Why? Add wallet level function for get historical balances: fetch historical balances for default address. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
Expose to_address_id method on Transaction class
### What changed? Why? Previously when creating MPC wallet's we were accidentally appending 2 identical wallet addresses to the cached addresses. This makes it so that when we're initially creating the wallet, we just do a full model reload instead of using the local cache. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
add webhook api to ruby sdk
(hotfix) fix conversion price
### What changed? Why? This refactors the Wallet class to use explicit delegators for forwarding to the default address so we do not need to redefine arguments in two places and potentially have them become out of sync. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This makes it so that the SDK passes the address index when deriving and registering addresses so that we can have a strong guarantee that the addresses are listed in address index order. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This removes the user concept as we do not support multiple users and it is confusing when reasoning about resource ownership. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This dynamically constructs network constants based on the network enum from our generated CDP service OpenAPI spec. This will construct the `Coinbase::Network::ALL` constant that enumerates the network objects. For each network this will also construct network constants like: `Coinbase::Network::BASE_SEPOLIA` This will enable us to use these constants in place of network IDs, for example: ``` Coinbase::Wallet.create(network: Coinbase::Network::BASE_MAINNET) ``` #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This injects the correlation context as request headers including the SDK version and language. This will better help assess what client SDK versions our developers are using so we can proactively reach out to developers on older versions. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
✅ Heimdall Review Status
|
jazz-cb
approved these changes
Aug 22, 2024
### What changed? Why? This bumps the client to use the new `WalletStakeApi` client as well as updates the changelog in anticipation of 0.1.0 #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This PR is a quick follow up to #157 and helps cleanup some of the unnecessary mocking in the prev PR. #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
- add webhook api to ruby sdk - [HistoricalBalances] add wallet level function (#148) - Expose to_address_id method on Transaction class - network id symbol - test cases - [chore] Fix MPC wallet address initailization (#154) - fix conversion price - Refactor Wallet class to use delegators (#136) - Pass address index when registering address (#150) - Remove the user concept (#153) - Add dynamic network constants (#138) - Inject correlation context headers (#158) - contract event ruby - update - Bump client and update changelog for v0.1.0 release (#161) - revert wallet level historical balances ### What changed? Why? #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
|
💇 @jazz-cb @John-peterson-coinbase Changes
|
jazz-cb
approved these changes
Aug 22, 2024
John-peterson-coinbase
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
[0.1.0] - 2024-08-22
historical_balances function for wallet: listing historical balances for default address of the wallet.
Coinbase::Network::ETHEREUM_MAINNETBreaking Changes
network_idnow take anetworkthat can be either a network constant (e.g.Coinbase::Network::BASE_MAINNET) or a network ID (e.g.:base_mainnet)Added
#148
#140
#154
#149
#156
#136
#150
#153
#138
#158
#155
#161
#157
Qualified Impact