LGTM Fixes: fixes for current LGTM issues (prebid#6851)

cointraffic · May 28, 2021 · 372119f · 372119f
1 parent 98f3653
commit 372119f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/integrationExamples/gpt/idImportLibrary_example.html b/integrationExamples/gpt/idImportLibrary_example.html
@@ -47,6 +47,7 @@
                 params: {
                   pid: '14', // Set your real identityLink placement ID here
                   // notUse3P: true // true/false - If you do not want to use 3P endpoint to retrieve envelope. If you do not set this property to true, 3p endpoint will be fired. By default this propertt is undefined and 3p request will be fired.},
+                },
                 storage: {
                   type: 'html5',
                   name: 'idl_env',

diff --git a/modules/aolBidAdapter.js b/modules/aolBidAdapter.js
@@ -366,7 +366,7 @@ export const spec = {
           let tagName = item.match(tagNameRegExp)[0];
           let url = item.match(srcRegExp)[2];
 
-          if (tagName && tagName) {
+          if (tagName && url) {
             pixelsItems.push({
               type: tagName === SYNC_TYPES.IMAGE.TAG ? SYNC_TYPES.IMAGE.TYPE : SYNC_TYPES.IFRAME.TYPE,
               url: url

diff --git a/modules/datablocksBidAdapter.js b/modules/datablocksBidAdapter.js
@@ -68,15 +68,15 @@ export const spec = {
         id: bidRequest.bidId,
         tagid: bidRequest.adUnitCode,
         secure: window.location.protocol == 'https:'
-      }
+      };
 
       if (utils.deepAccess(bidRequest, `mediaTypes.banner`)) {
         let sizes = bidRequest.mediaTypes.banner.sizes;
         if (sizes.length == 1) {
           imp.banner = {
             w: sizes[0][0],
             h: sizes[0][1]
-          }
+          };
         } else if (sizes.length > 1) {
           imp.banner = {
             format: sizes.map(size => ({ w: size[0], h: size[1] }))
@@ -181,7 +181,7 @@ export const spec = {
             if (VIDEO_PARAMS.indexOf(k) > -1) {
               imp.video[k] = bidRequest.params.video[k];
             }
-          })
+          });
         }
       }
       let host = bidRequest.params.host;

diff --git a/modules/gridBidAdapter.js b/modules/gridBidAdapter.js
@@ -350,7 +350,7 @@ function _addBidResponse(serverBid, bidRequest, bidResponses) {
         netRevenue: false,
         ttl: TIME_TO_LIVE,
         meta: {
-          advertiserDomains: serverBid && serverBid.adomain ? serverBid.adomain : []
+          advertiserDomains: serverBid.adomain ? serverBid.adomain : []
         },
         dealId: serverBid.dealid
       };