Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM Fixes: fixes for current LGTM issues #6851

Merged
merged 4 commits into from
May 27, 2021
Merged

Conversation

ChrisHuie
Copy link
Collaborator

@ChrisHuie ChrisHuie commented May 27, 2021

LGTM is taking a bit to run and the backlog of errors is growing so knocking out a few of them

@ChrisHuie ChrisHuie changed the title LGTM Fixes: fix for missing closing bracket from 1aeca20 LGTM Fixes: fixes for current LGTM errors May 27, 2021
@ChrisHuie ChrisHuie changed the title LGTM Fixes: fixes for current LGTM errors LGTM Fixes: fixes for current LGTM issues May 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request fixes 1 alert when merging 541751c into 7baf4b0 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request fixes 1 alert when merging 6b741de into 7baf4b0 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request fixes 4 alerts when merging ff9be11 into a5e7d08 - view on LGTM.com

fixed alerts:

  • 2 for Useless conditional
  • 1 for Identical operands
  • 1 for Syntax error

@patmmccann
Copy link
Collaborator

Are you planning on fixing the 200 semicolons it wants lol, very valiant of you

@patmmccann patmmccann merged commit d237cbf into master May 27, 2021
@patmmccann patmmccann deleted the ChrisHuie-lgtmFixes branch May 27, 2021 14:39
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants