Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook's like action style issue #38

Closed
keul opened this issue Feb 20, 2015 · 7 comments
Closed

Facebook's like action style issue #38

keul opened this issue Feb 20, 2015 · 7 comments
Assignees

Comments

@keul
Copy link
Member

keul commented Feb 20, 2015

Recently we noted that clicking on Facebook like action is opening a sort of overlay (not a popup) that current styles are forcing to be really small.

schermata 2015-02-20 a 09 24 38

The issue is related to iframe which is forced to be 23px in height.
The style has been added lot of years ago (ab07c98#diff-d195fc97c1e1fa75baa93a1e5d22519eR5) so I think that something's changed in Facebook generated HTML.

After removing the style I get this:

schermata 2015-02-20 a 09 32 21

Can we safely remove it of there are other related style issues?

@cleberjsantos
Copy link
Member

👍 Does not there are other related style issues, then, we can safely remove ;) @agnogueira ?

@keul
Copy link
Member Author

keul commented Feb 20, 2015

Let me know, I can take perform the change and some browser tests

@agnogueira
Copy link
Contributor

I think its related to old facebook button. +1 to remove

@keul keul self-assigned this Feb 20, 2015
@keul keul closed this as completed in baed101 Feb 20, 2015
@hvelarde
Copy link
Member

@keul I think an upgrade step for cooking the CSS registry was needed here; I already make a release but if you add it, I will release it again.

@keul
Copy link
Member Author

keul commented Feb 23, 2015

OK, I can fix this tomorrow

@keul
Copy link
Member Author

keul commented Feb 24, 2015

@hvelarde done, just do not release another version. I'm going to take over PR #15 and finally close all needed feature we have on sc.social.like

@hvelarde
Copy link
Member

thanks you, very much!

hvelarde added a commit to plonegovbr/portal.buildout that referenced this issue Jun 11, 2015
This fixes an issue with the Facebook widget (refs. collective/sc.social.like#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants