Add possibility to activate 'Share' with facebook button #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I have hear about Share action to be deprecated. can you verify this please ? |
|
Good point, I will take a look and make sure it will stay alive for a while (before merging) |
|
I don't really use a 'share' button, it's an option to the 'like' button to add a 'send' button. I dont think this is deprecated but it's a good idea to check it. |
|
what's the status on this? |
|
Don't know the status of this issue but this is one of the most asked features missing right now in the product |
|
@elioschmutz what's the status on this? could you please update the pull request? |
This was referenced Feb 24, 2015
Merged
|
superseded by #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we just can show a 'Like' type facebook button, it is interesting to add the possibility tu add the 'Share' button. This pull request add possibility to add the 'share' button by an option in the control panel.
It also remove the url 'hardcoded' in the viewlet and let take the informations from collective.opengraph og:url property.