Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook share button #40

Merged
merged 11 commits into from
Mar 2, 2015
Merged

Facebook share button #40

merged 11 commits into from
Mar 2, 2015

Conversation

keul
Copy link
Member

@keul keul commented Feb 24, 2015

Same issue from PR #15 (but I have no power on the affinitic fork to continue with it).
Providing the Facebook "Share" button is very easy with the new HTML 5 code but I added this disabled by default.

There's a couple of new translations message to be filled (italian already done)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.23%) to 96.54% when pulling 0552a91 on facebook-share into d85cbc3 on master.

@keul
Copy link
Member Author

keul commented Feb 24, 2015

Configuration note: right now the "Like" button is always shown while the "share" ones can be enabled/disabled.

If preferred I cal also change the checkbox button in a selection triplet like "show like only", "show share only", "show both".

@hvelarde
Copy link
Member

don't you think is a good idea to add some test on this new feature?

@keul
Copy link
Member Author

keul commented Feb 24, 2015

Yeah, absolutely. Just give me some hint on direction to take for configuration

@hvelarde
Copy link
Member

probably just activate the share button and see that it is present on a rendered page

@keul
Copy link
Member Author

keul commented Feb 24, 2015

@hvelarde sorry I meant something different (see my comment above). What about the configuration I did?
Right now a simple checkbox is displayed. It's acceptable or a selection of which button to display is better?

After this I can write tests.

@hvelarde
Copy link
Member

@agnogueira @ericof @cleberjsantos comments on this?

@keul
Copy link
Member Author

keul commented Feb 28, 2015

At the end I changed to code with an explicit selection of Like or Share button (see new screenshots for a preview), plus I fixed some other minor issues with i18n.

All done!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.37% when pulling e600b89 on facebook-share into d85cbc3 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.37% when pulling e600b89 on facebook-share into d85cbc3 on master.

hvelarde added a commit that referenced this pull request Mar 2, 2015
@hvelarde hvelarde merged commit 3a1aba9 into master Mar 2, 2015
@hvelarde hvelarde deleted the facebook-share branch March 2, 2015 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants