-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facebook share button #40
Conversation
Configuration note: right now the "Like" button is always shown while the "share" ones can be enabled/disabled. If preferred I cal also change the checkbox button in a selection triplet like "show like only", "show share only", "show both". |
don't you think is a good idea to add some test on this new feature? |
Yeah, absolutely. Just give me some hint on direction to take for configuration |
probably just activate the share button and see that it is present on a rendered page |
@hvelarde sorry I meant something different (see my comment above). What about the configuration I did? After this I can write tests. |
@agnogueira @ericof @cleberjsantos comments on this? |
At the end I changed to code with an explicit selection of Like or Share button (see new screenshots for a preview), plus I fixed some other minor issues with i18n. All done! |
Same issue from PR #15 (but I have no power on the affinitic fork to continue with it).
Providing the Facebook "Share" button is very easy with the new HTML 5 code but I added this disabled by default.
There's a couple of new translations message to be filled (italian already done)