chore: replace atty with is-terminal #122
Conversation
|
Having this merged and released would be awesome. Is |
hwittenborn
force-pushed
the
master
branch
3 times, most recently
from
744b5dd
to
1921f20
Compare
|
Thanks for the PR @jcgruenhage! This is being discussed at #85 (comment) as well, and it's the solution I'm wanting. An MSRV just needs to be figured out before anything is done, depending on what the |
|
As a side note: |
|
I'm definitely on the route for using the stdlib implementation too @ChrisCA, I just got to figure out what the fern people are fine with. If I can get this crate down to having zero external dependencies it would definitely be really nice, we just got to make sure all the big consumers for this crate are fine with the high MSRV so no one gets any unexpected breakage. |
|
I'm terribly sorry about this @jcgruenhage, but I was in a bit of a rush earlier getting Sadly that means there isn't really anything to merge in from this PR, but if you'd like to get another PR going I'd be more than glad to help! Let me know if there's anything I can do. |
|
Don't worry. My goal of getting |
``` warning[advisory-not-detected]: advisory was not encountered ┌─ /Users/taiki/projects/sources/smilerobotics/openrr/.deny.toml:16:5 │ 16 │ "RUSTSEC-2021-0145", # atty 0.2, transitively dep of rosrust (via colored, colored-rs/colored#122) │ ^^^^^^^^^^^^^^^^^^^ no crate matched advisory criteria ```
``` warning[advisory-not-detected]: advisory was not encountered ┌─ /Users/taiki/projects/sources/smilerobotics/openrr/.deny.toml:16:5 │ 16 │ "RUSTSEC-2021-0145", # atty 0.2, transitively dep of rosrust (via colored, colored-rs/colored#122) │ ^^^^^^^^^^^^^^^^^^^ no crate matched advisory criteria ```
``` warning[advisory-not-detected]: advisory was not encountered ┌─ /Users/taiki/projects/sources/smilerobotics/openrr/.deny.toml:16:5 │ 16 │ "RUSTSEC-2021-0145", # atty 0.2, transitively dep of rosrust (via colored, colored-rs/colored#122) │ ^^^^^^^^^^^^^^^^^^^ no crate matched advisory criteria ```
``` warning[advisory-not-detected]: advisory was not encountered ┌─ /Users/taiki/projects/sources/smilerobotics/openrr/.deny.toml:16:5 │ 16 │ "RUSTSEC-2021-0145", # atty 0.2, transitively dep of rosrust (via colored, colored-rs/colored#122) │ ^^^^^^^^^^^^^^^^^^^ no crate matched advisory criteria ```
attyis unmaintained and has a potential unaligned read. See https://github.com/rustsec/advisory-db/blob/main/crates/atty/RUSTSEC-2021-0145.md.is-terminalis a replacement based onatty, with the soundness issue fixed and an (IMO) nicer to use API, mirroring what's available in the std lib on nightly withstd::io::IsTerminal.