Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated boltdb and cleveldb #155

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Apr 11, 2024

No description provided.

@melekes melekes requested a review from a team as a code owner April 11, 2024 03:28
@melekes melekes self-assigned this Apr 11, 2024
Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, approved.

@melekes melekes added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit badc0b8 Apr 16, 2024
6 checks passed
@melekes melekes deleted the remove-boltdb-cleveldb branch April 16, 2024 14:45
@adizere adizere added this to the 2024-Q2 milestone Apr 24, 2024
@cason
Copy link
Contributor

cason commented Aug 7, 2024

#175

alesforz added a commit that referenced this pull request Aug 9, 2024
This reverts commit badc0b8.

We decided to reinstate boltDB and clevelDB and mark them as deprecated until a
future version of CometBFT in which we'll drop cometbft-db and support only 1 backend
DB.
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
* Revert "remove deprecated boltdb and cleveldb (#155)"

This reverts commit badc0b8.

We decided to reinstate boltDB and clevelDB and mark them as deprecated until a
future version of CometBFT in which we'll drop cometbft-db and support only 1 backend
DB.

* updated cleveldb Iterator API docs to conform to the changes made in #168

* updated go.mod

* updated boltDB Iterator APIs to conform to the changes made in #168

* added changelog entry

* Formatting

Co-authored-by: Daniel <daniel.cason@informal.systems>

* formatting to please the linter

* added additional context in the docs of backend types constants

---------

Co-authored-by: Daniel <daniel.cason@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants