Reinstate BoltDB and ClevelDB as backend DBs #177
Conversation
This reverts commit badc0b8. We decided to reinstate boltDB and clevelDB and mark them as deprecated until a future version of CometBFT in which we'll drop cometbft-db and support only 1 backend DB.
There was a problem hiding this comment.
This and reverted commits match.
The exception are some comments, probably added by another PR.
Also, I am not sure regarding the changelog. As it appears to me that we are dropping v0.13.0. In this way, just to remove the changelog should be enough. The reversion can be informed in the changelog for the new release.
There was a problem hiding this comment.
Do we need this changelog? Isn't easier to remove the previous one?
Co-authored-by: Daniel <daniel.cason@informal.systems>
Are you suggesting to delete the entire |
Context
We have decided to reinstate BoltDB and CLevelDB. These will remain marked as deprecated until a future version of CometBFT, where we plan to discontinue cometBFT-db and standardize on a single backend database.
Changes
This PR:
IteratorAPIs to comply with feat!: IteratorKey()andValue()no longer return a copy #168