-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reserved fields for body controls #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log.capnp
Outdated
@@ -2265,6 +2265,10 @@ struct Event { | |||
livestreamWideRoadEncodeData @121 :EncodeData; | |||
livestreamDriverEncodeData @122 :EncodeData; | |||
|
|||
customReservedText0 @124 :Text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would consider changing the text to data
sunnyhaibin
added a commit
to sunnypilot/msgq
that referenced
this pull request
Oct 13, 2023
* pre-commit: autoupdate hooks (commaai#532) Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com> * Update README.md (commaai#533) * pre-commit: autoupdate hooks (commaai#535) Update pre-commit hook versions Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com> * services: capitalize constant service list (commaai#534) * rename services * keep more unique name * type this * Bump pandaStates to 10hz (commaai#536) * 10 Hz * constant * fix * revert * fix peripheralState freq * revert peripheral * Bringing sunnypilot * Refactor service list and deprecate certain fields Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance. * pre-commit: autoupdate hooks (commaai#538) Update pre-commit hook versions Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com> * Added reserved fields for body controls (commaai#537) * Added bodyReserved0-2 text fields * Added bodyReserved0 to services list * add more bodyReserved to servcies py * bodyReserved -> customReservedText * :Text -> :Data --------- Co-authored-by: Kacper Rączy <gfw.kra@gmail.com> * zmq: assert the same PID (commaai#540) Enforce the same PID in ZMQ pub sockets * pre-commit: autoupdate hooks (commaai#541) Update pre-commit hook versions Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com> * Bringing sunnypilot * Refactor service list and deprecate certain fields Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance. * Bringing sunnypilot's cereal changes aligned * Converging cereal changes * accidentally duplicated some literals * Update log.capnp Co-authored-by: Jason Wen <haibin.wen3@gmail.com> --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com> Co-authored-by: JJ <103335846+computerscienceiscool@users.noreply.github.com> Co-authored-by: Shane Smiskol <shane@smiskol.com> Co-authored-by: Miguel Fernandez <miguel.fernandez@cimpress.com> Co-authored-by: Mitchell Goff <mitchellgoffpc@gmail.com> Co-authored-by: Kacper Rączy <gfw.kra@gmail.com> Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.