Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq: assert the same PID #540

Merged
merged 1 commit into from
Oct 2, 2023
Merged

zmq: assert the same PID #540

merged 1 commit into from
Oct 2, 2023

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Oct 1, 2023

ZMQ pub sockets cannot be shared between processes, and its behavior is undefined when they are.

Connected with: commaai/openpilot#30115

@fredyshox fredyshox marked this pull request as ready for review October 2, 2023 21:51
@fredyshox fredyshox merged commit acb24ff into master Oct 2, 2023
16 checks passed
@fredyshox fredyshox deleted the zmq-pid-enforcement branch October 2, 2023 22:03
sunnyhaibin added a commit to sunnypilot/msgq that referenced this pull request Oct 13, 2023
* pre-commit: autoupdate hooks (commaai#532)

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Update README.md (commaai#533)

* pre-commit: autoupdate hooks (commaai#535)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* services: capitalize constant service list (commaai#534)

* rename services

* keep more unique name

* type this

* Bump pandaStates to 10hz (commaai#536)

* 10 Hz

* constant

* fix

* revert

* fix peripheralState freq

* revert peripheral

* Bringing sunnypilot

* Refactor service list and deprecate certain fields

Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance.

* pre-commit: autoupdate hooks (commaai#538)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Added reserved fields for body controls (commaai#537)

* Added bodyReserved0-2 text fields

* Added bodyReserved0 to services list

* add more bodyReserved to servcies py

* bodyReserved -> customReservedText

* :Text -> :Data

---------

Co-authored-by: Kacper Rączy <gfw.kra@gmail.com>

* zmq: assert the same PID (commaai#540)

Enforce the same PID in ZMQ pub sockets

* pre-commit: autoupdate hooks (commaai#541)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Bringing sunnypilot

* Refactor service list and deprecate certain fields

Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance.

* Bringing sunnypilot's cereal changes aligned

* Converging cereal changes

* accidentally duplicated some literals

* Update log.capnp

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
Co-authored-by: JJ <103335846+computerscienceiscool@users.noreply.github.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Miguel Fernandez <miguel.fernandez@cimpress.com>
Co-authored-by: Mitchell Goff <mitchellgoffpc@gmail.com>
Co-authored-by: Kacper Rączy <gfw.kra@gmail.com>
Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant