Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru signals update #474

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

martinl
Copy link
Contributor

@martinl martinl commented Nov 24, 2021

This PR:

  • Adds Engine Stop-Start signals for global
  • Renames preglobal ES_ThrottleCruise message to ES_Distance to match global message and signals
  • Fixes/updates preglobal Car_Follow signal in ES_Distance (used for SNG)
  • Adds Brake, Cruise_Activated, Car_Follow and Far_Distance signals to ES_DashStatus message for Forester

I will submit openpilot PR for ES_Distance change and separate PR for adding SNG support

@adeebshihadeh
Copy link
Contributor

Next time, can you break up these changes a bit, at least into Global and Pre-Global?

@adeebshihadeh adeebshihadeh merged commit 2bab99f into commaai:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants