Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru SNG #23025

Closed
wants to merge 6 commits into from
Closed

Subaru SNG #23025

wants to merge 6 commits into from

Conversation

martinl
Copy link
Contributor

@martinl martinl commented Nov 24, 2021

***** Template: Refactor *****

Description
Subaru Stop and Go support for both global and preglobal models (for initial review).

Subaru stock ACC stops behind stopped cars but does not resume automatically. We send Throttle:Throttle_Pedal signal from openpilot to ACC when car in front starts moving to resume from ACC Hold state (mimicking stock ACC resume using gas press behaviour). It works for cars with electric parking brake and does not change stock ACC behaviour for cars with manual parking brake (which disengage 3 seconds after stopping).

For Global models, we also allow setting ACC hold manually when stopped with no lead car (eg at intersection/traffic light) and resume from manual hold only using ACC resume button press, same as stock ACC behaviour.

We tried to resume by sending ACC resume button press signals but that did not work since ACC buttons are directly wired to Eyesight and not accepted as input from CAN messages.

Prerequisites:

Verification
Subaru SNG implementation has been tested for several months in subaru-community branch. I will submit sample routes once this is ready to merge

Credit for initial implementation: @letsdudiss1

@adeebshihadeh
Copy link
Contributor

Is this ready for review yet? If not, can you convert the PR to a draft?

@martinl
Copy link
Contributor Author

martinl commented Jan 4, 2022

I would like to change global dbc to use real distance unit (m) at some point in the future, otherwise it's ready for review

@martinl
Copy link
Contributor Author

martinl commented May 7, 2022

Rebased the PR to latest master and changed Global models to use SI units (m) for ACC Close_Distance signal (with prerequisite commaai/opendbc#604)

@incognitojam incognitojam marked this pull request as draft December 8, 2022 03:12
@martinl
Copy link
Contributor Author

martinl commented May 5, 2023

I'll close this, new stop and go autoresume PR is #28064

@martinl martinl closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants